From nobody Tue Sep 5 18:19:51 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RgDLc06kLz4skHP; Tue, 5 Sep 2023 18:19:52 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RgDLb6h9Jz4CVM; Tue, 5 Sep 2023 18:19:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693937991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3rY4iK98Sao7vRvCuOc+Xz/OVx8UkhskYA93F9mZ6A0=; b=VG699LQviH4Mu7OSHMCULaD82kmj74M/vU21roC962Tb/ocHskN6SYWrxcC/HR/UqfYFQo 1bwJ8KQPREDqz6p6/QKTorJHgmBK+u2nZTXVxwkcxyIwTcq7y7kVkUImkirp3gAzXJ1Lvy JPU3LHK7vqOGbJmOCuUq60uKXw8wOCoi26WUEOaHHPlioJBCfmezstRCAQAiwzF2x9MISw 95pbHTbVeHibFc5pXeFxs8VqrrHesL4giJKfxSUBiMnoI0ZYF9hqdLh0zq1DwXtx794ddc 5cx5OdxjaqSCtNspe1cRCOCj01r5QEnhOldNdpk3zlmqnoGGC8s34R0dRHb18Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1693937991; a=rsa-sha256; cv=none; b=vCoZ5oPqLSkOnDCCU9n7hKSqMJO1dA7cMOHNPRz+f6wJ6w5DG1fr0p8NZur5VPTm2lD0UA l20OpWipaTy91nM8y/5ft3m7INPo6BsUNXT1oVJ3ugrpQyMQmCD4pdja9ahPhqAfDP8dV8 KR9aMjir9F4rADzPh5/0E2ELZRnR/okZyLR4g75Mf79JGxdl5irqB2dcYrmHdru2PRtLym qI/Mx9EoRZNwovYMXBvDL4F9typjKhSxxwyl40dn8HJypGq+Ek/ilvocodxv9/112+CTZV 6mWV527AbhNFloR9RUlRCLnUfyBBGd47mOnu9Eo8BXeNMO/yx3IMeveY1UWNmw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1693937991; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=3rY4iK98Sao7vRvCuOc+Xz/OVx8UkhskYA93F9mZ6A0=; b=IazZuERV9tB+G4QCLve3A1eZvJE0wyLuwsmPYu8znrOSoKYS35cBxrYYYoI/kwotU89aCM R/AhwvEQelZ4U+8O5lG8O/oTCerqCGGgITxeCbWGzWZ4ONAvLZsBWVQsUjJIlU8ptCIuEE 5H2FHdIX/tU0/lPCwuSG/rEq96CTHqzV5RHY3s3YCeN4ylg2VloMsYaDVYdhxH+EAj4gwv xQMs/oIIlmSKrNsk+nJBZ0C9ijz8cMKQGcuJhfWef4ZU3K51thhc+E/+ijqicn3XPmymwY LMiUFS+kFoBei8+orND1f4uDmOyWDGavPKgc3dwfT7rqiWL7JBRaz/hWN/orhQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RgDLb5hV3zk5t; Tue, 5 Sep 2023 18:19:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 385IJph9058477; Tue, 5 Sep 2023 18:19:51 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 385IJpLW058474; Tue, 5 Sep 2023 18:19:51 GMT (envelope-from git) Date: Tue, 5 Sep 2023 18:19:51 GMT Message-Id: <202309051819.385IJpLW058474@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Dmitry Chagin Subject: git: 20845a6994c5 - main - linux(4): Validate exec_setregs on arm64 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: dchagin X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 20845a6994c548977874d1f413044d43c8474f0a Auto-Submitted: auto-generated The branch main has been updated by dchagin: URL: https://cgit.FreeBSD.org/src/commit/?id=20845a6994c548977874d1f413044d43c8474f0a commit 20845a6994c548977874d1f413044d43c8474f0a Author: Dmitry Chagin AuthorDate: 2023-09-05 18:19:08 +0000 Commit: Dmitry Chagin CommitDate: 2023-09-05 18:19:08 +0000 linux(4): Validate exec_setregs on arm64 The lr register is cleared at the beginning of the _dl_start and _start, so there is no need to initialize it. Gnu libc _start takes an rtld_fini pointer in x0 which is set by ld.so for __libc_start_main, the kernel does not register any atexit pointers. While here fix whitespaces. MFC after: 1 week --- sys/arm64/linux/linux_sysvec.c | 21 ++------------------- 1 file changed, 2 insertions(+), 19 deletions(-) diff --git a/sys/arm64/linux/linux_sysvec.c b/sys/arm64/linux/linux_sysvec.c index 885ac4657380..3072732de768 100644 --- a/sys/arm64/linux/linux_sysvec.c +++ b/sys/arm64/linux/linux_sysvec.c @@ -51,7 +51,6 @@ #include #include -#include #include #include #include @@ -107,12 +106,6 @@ static void linux_exec_sysvec_init(void *param); static int linux_on_exec_vmspace(struct proc *p, struct image_params *imgp); -/* DTrace init */ -LIN_SDT_PROVIDER_DECLARE(LINUX_DTRACE); - -/* DTrace probes */ -LIN_SDT_PROBE_DEFINE0(sysvec, linux_exec_setregs, todo); - LINUX_VDSO_SYM_CHAR(linux_platform); LINUX_VDSO_SYM_INTPTR(kern_timekeep_base); LINUX_VDSO_SYM_INTPTR(__user_rt_sigreturn); @@ -178,19 +171,9 @@ linux_exec_setregs(struct thread *td, struct image_params *imgp, struct trapframe *regs = td->td_frame; struct pcb *pcb = td->td_pcb; - /* LINUXTODO: validate */ - LIN_SDT_PROBE0(sysvec, linux_exec_setregs, todo); - memset(regs, 0, sizeof(*regs)); - /* glibc start.S registers function pointer in x0 with atexit. */ - regs->tf_sp = stack; -#if 0 /* LINUXTODO: See if this is used. */ - regs->tf_lr = imgp->entry_addr; -#else - regs->tf_lr = 0xffffffffffffffff; -#endif - regs->tf_elr = imgp->entry_addr; - + regs->tf_sp = stack; + regs->tf_elr = imgp->entry_addr; pcb->pcb_tpidr_el0 = 0; pcb->pcb_tpidrro_el0 = 0; WRITE_SPECIALREG(tpidrro_el0, 0);