From owner-freebsd-stable@freebsd.org Mon Feb 1 22:11:37 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A87F3A98A47 for ; Mon, 1 Feb 2016 22:11:37 +0000 (UTC) (envelope-from mike@sentex.net) Received: from smarthost2.sentex.ca (smarthost2.sentex.ca [IPv6:2607:f3e0:80:80::2]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "smarthost.sentex.ca", Issuer "smarthost.sentex.ca" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0B547110E for ; Mon, 1 Feb 2016 22:11:36 +0000 (UTC) (envelope-from mike@sentex.net) Received: from lava.sentex.ca (lava.sentex.ca [IPv6:2607:f3e0:0:5::11]) by smarthost2.sentex.ca (8.15.2/8.15.2) with ESMTPS id u11MBZnQ092192 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 1 Feb 2016 17:11:35 -0500 (EST) (envelope-from mike@sentex.net) Received: from [IPv6:2607:f3e0:0:4:5c30:ed1b:e203:c55c] ([IPv6:2607:f3e0:0:4:5c30:ed1b:e203:c55c]) by lava.sentex.ca (8.14.9/8.14.9) with ESMTP id u11MBX4S008203; Mon, 1 Feb 2016 17:11:33 -0500 (EST) (envelope-from mike@sentex.net) Subject: Re: possible em regression (was Re: svn commit: r294958 - in stable/10: share/man/man4 sys/dev/e1000 sys/dev/ixgb sys/dev/netmap) To: Marius Strobl References: <201601272231.u0RMV8LW019394@repo.freebsd.org> <56ABAA92.5050901@sentex.net> <56ABB291.5040305@omnilan.de> <56ABCE95.3030807@sentex.net> <20160130012358.GY15359@alchemy.franken.de> <56ACE917.80502@sentex.net> <20160130172618.GA15359@alchemy.franken.de> Cc: FreeBSD-STABLE Mailing List From: Mike Tancsa Organization: Sentex Communications Message-ID: <56AFD811.1030706@sentex.net> Date: Mon, 1 Feb 2016 17:11:29 -0500 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160130172618.GA15359@alchemy.franken.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.75 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Feb 2016 22:11:37 -0000 On 1/30/2016 12:26 PM, Marius Strobl wrote: > > Ah, okay, that at least makes sense. Can you please verify that with > the attached patch applied, you have a setup that works out of the > box? > Hi, The patch does not apply cleanly # patch < em_tso_gig_only_10.diff Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |Index: sys/dev/e1000/if_em.c |=================================================================== |--- sys/dev/e1000/if_em.c (revision 294962) |+++ sys/dev/e1000/if_em.c (working copy) -------------------------- Patching file sys/dev/e1000/if_em.c using Plan A... Hunk #1 failed at 1377. 1 out of 1 hunks failed--saving rejects to sys/dev/e1000/if_em.c.rej done # cat sys/dev/e1000/if_em.c.rej @@ -1377,8 +1377,15 @@ ifp->if_hwassist = 0; if (ifp->if_capenable & IFCAP_TXCSUM) ifp->if_hwassist |= (CSUM_TCP | CSUM_UDP); - if (ifp->if_capenable & IFCAP_TSO4) - ifp->if_hwassist |= CSUM_TSO; + /* + ** There have proven to be problems with TSO when not + ** at full gigabit speed, so disable the assist automatically + ** when at lower speeds. -jfv + */ + if (ifp->if_capenable & IFCAP_TSO4) { + if (adapter->link_speed == SPEED_1000) + ifp->if_hwassist |= CSUM_TSO; + } /* Configure for OS presence */ em_init_manageability(adapter); -- ------------------- Mike Tancsa, tel +1 519 651 3400 Sentex Communications, mike@sentex.net Providing Internet services since 1994 www.sentex.net Cambridge, Ontario Canada http://www.tancsa.com/