Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 10 Dec 2010 21:38:51 +0000 (UTC)
From:      "Kenneth D. Merry" <ken@FreeBSD.org>
To:        cvs-src-old@freebsd.org
Subject:   cvs commit: src/sbin/camcontrol camcontrol.c src/sys/cam cam_periph.c src/sys/cam/scsi scsi_pass.c
Message-ID:  <201012102139.oBALdqHF054198@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
ken         2010-12-10 21:38:51 UTC

  FreeBSD src repository

  Modified files:
    sbin/camcontrol      camcontrol.c 
    sys/cam              cam_periph.c 
    sys/cam/scsi         scsi_pass.c 
  Log:
  SVN rev 216361 on 2010-12-10 21:38:51Z by ken
  
  Fix a few issues related to the XPT_GDEV_ADVINFO CCB.
  
  camcontrol.c:   In buildbusdevlist(), don't attempt to get call
                  getdevid() for an unconfigured device, even when the
                  verbose flag is set.  The cam_open_btl() call will almost
                  certainly fail.
  
                  Probe for the buffer size when issuing the XPT_GDEV_ADVINFO
                  CCB.  Probing for the buffer size first helps us avoid
                  allocating the maximum buffer size when it really may not
                  be necessary.  This also helps avoid errors from
                  cam_periph_mapmem() if we attempt to map more than MAXPHYS.
  
  cam_periph.c:   In cam_periph_mapmem(), if the XPT_GDEV_ADVINFO CCB
                  shows a bufsiz of 0, we don't have anything to map,
                  so just return.
  
                  Also, set the maximum mapping size to MAXPHYS
                  instead of DFLTPHYS for XPT_GDEV_ADVINFO CCBs,
                  since they don't actually go down to the hardware.
  
  scsi_pass.c:    Don't bother mapping the buffer in XPT_GDEV_ADVINFO
                  CCBs if bufsiz is 0.
  
  Revision  Changes    Path
  1.84      +34 -12    src/sbin/camcontrol/camcontrol.c
  1.92      +9 -0      src/sys/cam/cam_periph.c
  1.58      +5 -4      src/sys/cam/scsi/scsi_pass.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201012102139.oBALdqHF054198>