From owner-svn-ports-all@freebsd.org  Sun Jul 15 23:20:08 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 626DF102F10D;
 Sun, 15 Jul 2018 23:20:08 +0000 (UTC)
 (envelope-from pierre@guinoiseau.nz)
Received: from mail-01.yggdrasil.nz (mail-01.yggdrasil.nz
 [IPv6:2a01:4f8:171:1cf0::10:1])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E6AA474DB7;
 Sun, 15 Jul 2018 23:20:04 +0000 (UTC)
 (envelope-from pierre@guinoiseau.nz)
Received: from mllwwlg044.magicleap.ds (unknown [4.7.11.146])
 (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mail-01.yggdrasil.nz (Postfix) with ESMTPSA id A5A8521707;
 Mon, 16 Jul 2018 11:19:58 +1200 (NZST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=guinoiseau.nz;
 s=mail; t=1531696800;
 bh=SgPjnZpQSSNg93McO2WZorf9yfoPLVwxik9NORuZ9ns=;
 h=Subject:From:In-Reply-To:Date:Cc:References:To;
 b=i5P2uDa9E2hnBzhoaPZ9UWVXPq1n3tdx9Tk4061Jcl0g0ZIf66eXLIoWGULgNik9S
 146i5iGSHvxwS4YOgLSckKnGmzR0UeESK9L+BhmuA+lu2f4CFJt1GQKgAwWkJhYfI3
 ost4e7q3hUUeSSkAwLsOSmfHq3dIYscZ+r7KESkc=
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 11.5 \(3445.9.1\))
Subject: Re: svn commit: r473981 - in branches/2018Q3/www/py-graphite-api: .
 files
From: Pierre Guinoiseau <pierre@guinoiseau.nz>
In-Reply-To: <201807051903.w65J3mPr021455@repo.freebsd.org>
Date: Mon, 16 Jul 2018 11:19:51 +1200
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-branches@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <733A982D-22D8-49E1-A0D0-8436206488AD@guinoiseau.nz>
References: <201807051903.w65J3mPr021455@repo.freebsd.org>
To: Dave Cottlehuber <dch@FreeBSD.org>
X-Mailer: Apple Mail (2.3445.9.1)
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 15 Jul 2018 23:20:08 -0000


> On 6/07/2018, at 07:03, Dave Cottlehuber <dch@FreeBSD.org> wrote:
>=20
> +start_precmd()
> +{
> +    test -d "%%GRAPHITEAPI_LOGDIR%%" || install -d -o
> +    ${graphiteapi_user} \

There is either an extra newline or a missing backslash on that line, =
causing an error on startup and a potentially missing log directory.=20

> +        -g ${graphiteapi_group} -m 0750 "%%GRAPHITEAPI_LOGDIR%%"
> +    test -d "%%GRAPHITEAPI_TMPDIR%%" || install -d -o =
${graphiteapi_user} \
> +        -g ${graphiteapi_group} -m 0750 "%%GRAPHITEAPI_TMPDIR%%"
> +}

=E2=80=94
Pierre Guinoiseau <pierre@guinoiseau.nz>
https://segmentationfau.lt/ | +PierreGuinoiseau | @peikk00