From owner-svn-src-head@freebsd.org Tue Sep 3 13:02:54 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DB9D8DA495; Tue, 3 Sep 2019 13:02:54 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-ot1-x343.google.com (mail-ot1-x343.google.com [IPv6:2607:f8b0:4864:20::343]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N6Z620x9z4Kg8; Tue, 3 Sep 2019 13:02:54 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-ot1-x343.google.com with SMTP id 97so13778261otr.4; Tue, 03 Sep 2019 06:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=a68tOxX6Vyoq0I7HSCACMWW0Jgqv+QgVyflgQk89vLI=; b=LIDsf+tCOiU7Lp/n/IIMZOFDfW532wFs4+k8UuO3LH5t4Ib9NMlqYjw170yIw4luwE YUV3Bx/KTJE6HaFzT1x85qt9facMt6/GKXEB3dtXWWdwjdr7Ob35cTsaIeAXJED8+/GH ugmzQwmIpIPcYz79PHduEXucEe1fD5d8RiTNf7Nj8Y1nT6vuYH4se3niiiFasgGJ24iC B+CVJCf/7sdZ4cd/8FNdl0bBjEhaUsSOCoOXGRyYqHMjV2uUrq2I93Vl/ih7HCB4wB7c y17NQeRxT0UxhzQ+o4cHyzSEKQTNEcsP88vMpMDOLt1QkSTzlo5RrZbR6K56OwFhILN5 rUNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=a68tOxX6Vyoq0I7HSCACMWW0Jgqv+QgVyflgQk89vLI=; b=MmlfMFFZ/bKl7nLa8unUOdgP/k07HgjGEJBy3gsc5a+HYWXrqq078+ENgrI/uZG86E 61pYkaI2I9Ht42xcOlqqKVnptN3BCYA+SZ4wG91pdGmqLOBYy0lO7CSxScKPB9ADR8Wp CXqNlpwbxSQLWtyeBRtEYyOI7hNksPFTswfAZ5Ti3/neTvjOjc+c+wJcZIfj84IDrnJe j4gm3JctN5CiToqY8mjan6JJmpaqxgpdmJQlXe+U7IbgyfNH+MJv8pbaHR/vde3aT9wg CxOHMzDYPgTqXFrKShspL8LFpas0nN2b0Wk4M8UJXFbxjZfNpdBw37cPrtGz50P0SKDS KEfw== X-Gm-Message-State: APjAAAV6cTBCgUnpG9wmvKLPyehZMsCqXY6of59GHzJTzgB03cP3S5L+ r0xeNeiAnysz8qdKQEmb8+G9HZmfIlT6uEbYZ56MVA== X-Google-Smtp-Source: APXvYqw/pVLySZjTZ2bGAR7DelfNPknTX7DWiwNenxPAhLqYnOwMnFH/DW7y4mnRzRaa/0tcEbsR4G00RW4g1XdDME4= X-Received: by 2002:a05:6830:187:: with SMTP id q7mr29361873ota.23.1567515773107; Tue, 03 Sep 2019 06:02:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a4a:458d:0:0:0:0:0 with HTTP; Tue, 3 Sep 2019 06:02:52 -0700 (PDT) In-Reply-To: References: <201909030416.x834GVwk004191@repo.freebsd.org> <20190903113505.ckbx5i34onmin557@mutt-hbsd> <20190903114523.GA68094@spindle.one-eyed-alien.net> From: Mateusz Guzik Date: Tue, 3 Sep 2019 15:02:52 +0200 Message-ID: Subject: Re: svn commit: r351729 - in head: lib/libc/gen lib/libc/sys sys/compat/freebsd32 sys/kern sys/sys To: Warner Losh Cc: Brooks Davis , Shawn Webb , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 46N6Z620x9z4Kg8 X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=LIDsf+tC; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of mjguzik@gmail.com designates 2607:f8b0:4864:20::343 as permitted sender) smtp.mailfrom=mjguzik@gmail.com X-Spamd-Result: default: False [-3.96 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(0.00)[ip: (3.05), ipnet: 2607:f8b0::/32(-2.82), asn: 15169(-2.30), country: US(-0.05)]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE_FREEMAIL(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; RCVD_IN_DNSWL_NONE(0.00)[3.4.3.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.96)[-0.964,0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Sep 2019 13:02:54 -0000 On 9/3/19, Warner Losh wrote: > On Tue, Sep 3, 2019, 5:45 AM Brooks Davis wrote: > >> On Tue, Sep 03, 2019 at 07:35:05AM -0400, Shawn Webb wrote: >> > Hey Mateusz, >> > >> > On Tue, Sep 03, 2019 at 04:16:31AM +0000, Mateusz Guzik wrote: >> > > Author: mjg >> > > Date: Tue Sep 3 04:16:30 2019 >> > > New Revision: 351729 >> > > URL: https://svnweb.freebsd.org/changeset/base/351729 >> > > >> > > Log: >> > > Add sysctlbyname system call >> > > >> > > Previously userspace would issue one syscall to resolve the sysctl >> and then >> > > another one to actually use it. Do it all in one trip. >> > > >> > > Fallback is provided in case newer libc happens to be running on an >> older >> > > kernel. >> > > >> > > Submitted by: Pawel Biernacki >> > > Reported by: kib, brooks >> > > Differential Revision: https://reviews.freebsd.org/D17282 >> > > >> > > Modified: >> > ... snip ... >> > > head/sys/sys/param.h >> > >> > ... snip ... >> > >> > > >> > > Modified: head/sys/sys/param.h >> > > >> ============================================================================== >> > > --- head/sys/sys/param.h Mon Sep 2 21:57:57 2019 (r351728) >> > > +++ head/sys/sys/param.h Tue Sep 3 04:16:30 2019 (r351729) >> > > @@ -60,7 +60,7 @@ >> > > * in the range 5 to 9. >> > > */ >> > > #undef __FreeBSD_version >> > > -#define __FreeBSD_version 1300044 /* Master, propagated to newvers >> > > */ >> > > +#define __FreeBSD_version 1300045 /* Master, propagated to newvers >> > > */ >> > >> > To an outsider, it seems that __FreeBSD_version tends to be bumped in >> > a separate commit. Am I remembering that right? >> >> It should be bumped in the same commit, but people forget or the bump >> they have in their review turns into a no-op because someone else does a >> bump in the interim (the latter has bit me several times). >> > > Often when that happens to me, I'll just piggyback off the prior bump by > just documenting the version bump as also covering what I just did. Though > there is some judgement too based on number of days and how bad the effects > in the in between zone might be. It's always a fuzzy thing if you zoom in > on it, though, due to after the fact bumps. > How do you run into this one? Your patch should fail on the file, then patch itself exits with an error. -- Mateusz Guzik