From nobody Sat Nov 30 19:57:04 2024 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Y11683kbhz5fZ82; Sat, 30 Nov 2024 19:57:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Y11681zq2z4QR3; Sat, 30 Nov 2024 19:57:04 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732996624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L2gqHIV2eglGVusdTNxUW09vxY2JpLal+THcpHKPOBw=; b=EgbHkmF0cnIwkUn/qmRnJOHOM9s9vLG8CxNUxhRNHcaeYbqGgMnUMHgVgT8Np5vOOgnugj TIaGiBNsILDDQWirR0OKATvHeG3BpTmQerflwt+aO9/XMOzlBc5ukaf8rcZb8VEsAjvdTg 8lFRvudNL4Yq1WlBy/JSaGifvDD28Yo7rQWV41q3fMeY8AV7sQdXuh5mLCZpmf5G8DmO32 TOVfD39PDlDYMkUx0NaA7MpUVioz/tF2gdeNjsPyHQNloSJSmgOU9bm4rzdFGhE6Srd24Q CtfvoAsnfb2cUOvT1m5E7hjp0fiqTaCEtw3FD/gyeBBQthorzu10GzdgtCLzHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1732996624; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=L2gqHIV2eglGVusdTNxUW09vxY2JpLal+THcpHKPOBw=; b=tpY0yT5fiY7MkObHJ6UWqsk2m6ET13d8Sb1CufI54RdOhITeZrfj4k7Kalf1wwPd++h7Tf 19Ohm4J72ouVUQruSjiT2yhnsCBOQrzAvwpnJ0ysuVVyUiMcewMsHJdSHIRn+DdQtZgSn0 Z6cmn/f6nIhasYbmJVeVbnr2psISBVZUGg8Xq+rXj6UT2druYZwJ4qoOCphFgquRSVrdmw x9czTegqu+1OqI8x7i1BVTuV83gImzf6kNeNsh00b6OAF3Gne60q3L40/MYB0TAsi74w9W PkhMvZjkHS4fd1LLOvE+VjurqvuAG8SJrVIhYjtgyrtAvB2rdn5jGVWJsScDXQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1732996624; a=rsa-sha256; cv=none; b=KuzYpK37tZqk9Jd1huMVYtncfse5P/DfqWQPLbT+xr4i2TDs3QILYGfg2nF/FZIq9n+EPh RG00UunV3Zjk1nrJ1f/eB4Euvj8GrNk8fIRqp/jNT0HFSWSxjQPV8BfBaoci6syyrOQseq 0e49amZhYBDUUYD5YGIs9rAGyaWCIWq6H1z8eG6VHy/0lSuuh/Nn2gut4mLtVRJZm6pzAL 8JINw7ASmUSDj/UO4fugJ/BSmL8hNiTHbr/blXKKe+beGhZfGI9cvDjBhwv8ijv/Ew5W/a y2YvFpRD+Hm5aKGFURTfgdpkLB1n6bKKKrcMFATfoeAOIvMk9Yjp1ykOvRVLIg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Y11681bp5zM6P; Sat, 30 Nov 2024 19:57:04 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AUJv477089391; Sat, 30 Nov 2024 19:57:04 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AUJv4o2089388; Sat, 30 Nov 2024 19:57:04 GMT (envelope-from git) Date: Sat, 30 Nov 2024 19:57:04 GMT Message-Id: <202411301957.4AUJv4o2089388@gitrepo.freebsd.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org From: Muhammad Moinur Rahman Subject: git: 2a6b6cf4bdc7 - main - lang/spidermonkey78: Fix build with libc++ 19 List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-ports-all@freebsd.org Sender: owner-dev-commits-ports-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bofh X-Git-Repository: ports X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2a6b6cf4bdc755c69c1142dc8266f35f7327dccc Auto-Submitted: auto-generated The branch main has been updated by bofh: URL: https://cgit.FreeBSD.org/ports/commit/?id=2a6b6cf4bdc755c69c1142dc8266f35f7327dccc commit 2a6b6cf4bdc755c69c1142dc8266f35f7327dccc Author: Dimitry Andric AuthorDate: 2024-11-30 15:15:51 +0000 Commit: Muhammad Moinur Rahman CommitDate: 2024-11-30 17:16:28 +0000 lang/spidermonkey78: Fix build with libc++ 19 Clang 19 now diagnoses incorrect member accesses, which causes lang/spidermonkey78 to fail with an error similar to: /wrkdirs/usr/ports/lang/spidermonkey78/work/firefox-78.15.0/js/src/threading/ExclusiveData.h:113:29: error: reference to non-static member function must be called 113 | : lock_(std::move(rhs.lock)), value_(std::move(rhs.value_)) { | ~~~~^~~~ Upstream fixed this for https://bugzilla.mozilla.org/1894423 in changeset 223087fdc29f18678f6174e9807b8780e439acf6 [2], so pull this in as a patch and apply it. Also, as noted in the libc++ 19 release notes [1], std::char_traits<> is now only provided for char, char8_t, char16_t, char32_t and wchar_t, and any instantiation for other types will fail. With lang/spidermonkey78 and clang/libc++ 19 this results in errors similar to: /wrkdirs/usr/ports/lang/spidermonkey78/work/fireox-78.15.0/js/src/builtin/intl/Locale.cpp:208:20: error: implicit instantiation of undefined template 'std::char_traits' 208 | iter_ = std::char_traits::find( | ^ /wrkdirs/usr/ports/lang/spidermonkey78/work/fireox-78.15.0/js/src/builtin/intl/Locale.cpp:769:21: note: in instantiation of member function 'SepKeywordIterator::next' requested here 769 | beginKey = iter.next(); | ^ /wrkdirs/usr/ports/lang/spidermonkey78/work/fireox-78.15.0/js/src/builtin/intl/Locale.cpp:808:16: note: in instantiation of function template specialization 'FindUnicodeExtensionType' requested here 808 | ? FindUnicodeExtensionType(unicodeExtension->latin1Chars(nogc), | ^ Upstream fixed this for https://bugzilla.mozilla.org/1849070 in changeset 68ff4d3f7338248b4d67cf03aade5a73f8d396b2 [3], so pull this in as a patch and apply it. See also bug 280730, for lang/spidermonkey102. [1] https://libcxx.llvm.org/ReleaseNotes/19.html#deprecations-and-removals [2] https://hg.mozilla.org/mozilla-central/rev/223087fdc29f18678f6174e9807b8780e439acf6 [3] https://hg.mozilla.org/mozilla-central/rev/68ff4d3f7338248b4d67cf03aade5a73f8d396b2 PR: 283050 Reported by: dim MFH: 2024Q4 --- lang/spidermonkey78/Makefile | 4 ++++ lang/spidermonkey78/distinfo | 6 +++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/lang/spidermonkey78/Makefile b/lang/spidermonkey78/Makefile index ed1565c19223..2fedfd5797e8 100644 --- a/lang/spidermonkey78/Makefile +++ b/lang/spidermonkey78/Makefile @@ -6,6 +6,10 @@ MASTER_SITES= MOZILLA/firefox/releases/${DISTVERSION}esr/source PKGNAMESUFFIX= ${SP_VER} DISTNAME= firefox-${DISTVERSION}esr.source +PATCH_SITES= https://hg.mozilla.org/mozilla-central/raw-rev/ +PATCHFILES+= 223087fdc29f18678f6174e9807b8780e439acf6:-p1 # https://bugzilla.mozilla.org/1894423 +PATCHFILES+= 68ff4d3f7338248b4d67cf03aade5a73f8d396b2:-p1 # https://bugzilla.mozilla.org/1849070 + MAINTAINER= bofh@FreeBSD.org COMMENT= Standalone JavaScript based from Mozilla 78-esr WWW= https://spidermonkey.dev/ diff --git a/lang/spidermonkey78/distinfo b/lang/spidermonkey78/distinfo index 3520a72f3018..a54d8d3ed35f 100644 --- a/lang/spidermonkey78/distinfo +++ b/lang/spidermonkey78/distinfo @@ -1,3 +1,7 @@ -TIMESTAMP = 1651603084 +TIMESTAMP = 1732978996 SHA256 (firefox-78.15.0esr.source.tar.xz) = a4438d84d95171a6d4fea9c9f02c2edbf0475a9c614d968ebe2eedc25a672151 SIZE (firefox-78.15.0esr.source.tar.xz) = 330819568 +SHA256 (223087fdc29f18678f6174e9807b8780e439acf6) = f234371584e2b2bc9953ae4fd145da19c99a6f04087f53d59616aecf29df039c +SIZE (223087fdc29f18678f6174e9807b8780e439acf6) = 1597 +SHA256 (68ff4d3f7338248b4d67cf03aade5a73f8d396b2) = 8d556dcb0d3a76a6cb8870b6eff45fafe0a78760ea24d34ea0b5e7ceb4489a71 +SIZE (68ff4d3f7338248b4d67cf03aade5a73f8d396b2) = 2546