From nobody Mon Aug 29 18:00:28 2022 X-Original-To: freebsd-stable@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4MGdX15DjWz4bbGp for ; Mon, 29 Aug 2022 18:00:33 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4MGdX04tndz3Tfn; Mon, 29 Aug 2022 18:00:32 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: by mail-qk1-x730.google.com with SMTP id b9so6649436qka.2; Mon, 29 Aug 2022 11:00:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc; bh=ZLE3iLzIWrIEwz18cnoPzxCtO+UEn3OihRAsZH+sglc=; b=QVsVfzPUiNW3rCNf9zijVxIOfInn9QaVpZVmx1v7lYQgXjlABZoo0buEr875Go+yEB k3BVpsKwtCMIHNUD/Jv90hQ/3xTmt/rEyfMWzIwN8bMJCOip+WrUhqQpMoazoQ694MYI u1xanheiQtzTSqmvfwN5ZeRr8cIP9cOPP1I4IG+60aGrLQ4HopSBQneOvds6OaAr8xp8 UKLzA6VwJnLxdbHCHjiCyqTB08wjSIWwatoIszpKpm4HnzBrxKQyBIoqDcHHCGS8Z/CD emDRbSazGsT911VRtXfB53MyQTQ2l/76sc06OcNeu1/2o788bmsaNMK1btLlds5eG5yw 75tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc; bh=ZLE3iLzIWrIEwz18cnoPzxCtO+UEn3OihRAsZH+sglc=; b=qmCBvF4hbv6/6plNAl8VowFRGUP8hvqQnqpQBKx593Kkv6ZkT199mXXw3bmA78j3Cl ZK4ir2laAwwMB3QCFou/h26L7At4aKsIK8QiSVL+PQON91QdW1HPtWH3mLIULdjn09Rb Wr4JAriU28KSHvlFnSgoCdVANCTAscZAKdjiyf/V4iSazquwHcxvNnHWaDbfHCk7gJSx px5G6zHZAy7Ms+RIRoI0jTeuJLqaBGBunR4JuJrGvLFrG7ZCmR094Z3XmhjjBiMEGPqa tbKV5T50IhsZub/3FypQFO5BR2iFZRFUwEAy7J/cyG2KBqMQGXyTyCg0LzJqw7iARZj5 YFKQ== X-Gm-Message-State: ACgBeo3muJZNmeF2uHvVVKLRH4OZNxfBzs/IBlsWuO9OAi6osaBjDsdX BiLQiU3oyebL3po1fuWE/HYIktm501s= X-Google-Smtp-Source: AA6agR76r0JB+8hVSbLoG7EOU8wOMzD6aKaYp9aH6wNaFBc/YP/MmWHIjdiKsnQHJwrwKIssQACj1g== X-Received: by 2002:a37:9ad4:0:b0:6b9:c5d1:74e2 with SMTP id c203-20020a379ad4000000b006b9c5d174e2mr9057508qke.319.1661796031240; Mon, 29 Aug 2022 11:00:31 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id h22-20020a05620a245600b006bc1512986esm6436449qkn.97.2022.08.29.11.00.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 29 Aug 2022 11:00:30 -0700 (PDT) Date: Mon, 29 Aug 2022 14:00:28 -0400 From: Mark Johnston To: Alexander Motin Cc: Matthew Grooms , freebsd-stable@freebsd.org Subject: Re: CAM IOCTL issue with 13.1-STABLE Message-ID: References: <3caeafa8-6c9c-2632-9010-9c8e21098378@FreeBSD.org> List-Id: Production branch of FreeBSD source code List-Archive: https://lists.freebsd.org/archives/freebsd-stable List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-stable@freebsd.org X-BeenThere: freebsd-stable@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3caeafa8-6c9c-2632-9010-9c8e21098378@FreeBSD.org> X-Rspamd-Queue-Id: 4MGdX04tndz3Tfn X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20210112 header.b=QVsVfzPU; dmarc=none; spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::730 as permitted sender) smtp.mailfrom=markjdb@gmail.com X-Spamd-Result: default: False [-2.68 / 15.00]; NEURAL_HAM_LONG(-1.00)[-0.999]; NEURAL_HAM_SHORT(-0.99)[-0.995]; NEURAL_HAM_MEDIUM(-0.99)[-0.985]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20210112]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36:c]; MIME_GOOD(-0.10)[text/plain]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::730:from]; MLMMJ_DEST(0.00)[freebsd-stable@freebsd.org]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_THREE(0.00)[3]; DMARC_NA(0.00)[freebsd.org]; RCVD_TLS_LAST(0.00)[]; TO_DN_SOME(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim] X-ThisMailContainsUnwantedMimeParts: N On Tue, Aug 23, 2022 at 09:44:48AM -0400, Alexander Motin wrote: > Hi Matthew, > > I took a brief look on it and found that CAM compatibility code just > does not cover that IOCTL. That is why when CAM version was bumped it > cause the unexpected breakage. Short term fix would be to rebuild the > application to new CAM version, while for proper fix somebody would have > to implement the compatibility code for that IOCTL. I looked at this a bit more, and it seems trivial since 1) for periph drivers, CAMGETPASSTHRU ignores the input CCB, and 2) the CAM version bump from 0x19 to 0x1a does not affect XPT_GDEVLIST CCBs. Note for instance that cam_compat_handle_0x19() is a no-op for CAMGETPASSTHRU. So, isn't the patch here sufficient? https://reviews.freebsd.org/D36389 > On 22.08.2022 14:48, Matthew Grooms wrote: > > There appears to be a problem with XPT_DEV_MATCH CAM IOCTL calls. This > > prevents a bunch of packages on 13.1-STABLE from working correctly. A > > bug was filed and Mark J was kind enough to help diagnose the issue, but > > it's sitting in unassigned status. Can someone please assign it to the > > correct group so it gets some attention? > > > > The FreeBSD bug: > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264709 > > > > The offending commit ( I think? ): > > https://cgit.freebsd.org/src/commit/sys/cam/cam_ccb.h?h=stable/13&id=7d7168478380f08b3a7fd58ca7cf83182fae6850 > > -- > Alexander Motin >