From owner-p4-projects@FreeBSD.ORG  Wed May 24 21:59:22 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id B078816A5B1; Wed, 24 May 2006 21:59:21 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5314916A4E0
	for <perforce@freebsd.org>; Wed, 24 May 2006 21:59:21 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 08F6A43D46
	for <perforce@freebsd.org>; Wed, 24 May 2006 21:59:21 +0000 (GMT)
	(envelope-from jhb@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4OLwSFW074988
	for <perforce@freebsd.org>; Wed, 24 May 2006 21:58:28 GMT
	(envelope-from jhb@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4OLwSte074985
	for perforce@freebsd.org; Wed, 24 May 2006 21:58:28 GMT
	(envelope-from jhb@freebsd.org)
Date: Wed, 24 May 2006 21:58:28 GMT
Message-Id: <200605242158.k4OLwSte074985@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	jhb@freebsd.org using -f
From: John Baldwin <jhb@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 97769 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 May 2006 21:59:23 -0000

http://perforce.freebsd.org/chv.cgi?CH=97769

Change 97769 by jhb@jhb_mutex on 2006/05/24 21:57:33

	No longer need Giant here.
	
	Spotted by:    sam

Affected files ...

.. //depot/projects/smpng/sys/kern/subr_firmware.c#2 edit

Differences ...

==== //depot/projects/smpng/sys/kern/subr_firmware.c#2 (text+ko) ====

@@ -197,9 +197,7 @@
 		    "load firmware image %s\n", __func__, imagename);
 		return NULL;
 	}
-	mtx_lock(&Giant);		/* XXX */
 	(void) linker_reference_module(imagename, NULL, &result);
-	mtx_unlock(&Giant);		/* XXX */
 	requested_load = 1;
 	goto again;		/* sort of an Algol-style for loop */
 }