From owner-svn-src-all@FreeBSD.ORG  Tue Jun 19 02:17:50 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 46C8A106564A;
	Tue, 19 Jun 2012 02:17:50 +0000 (UTC)
	(envelope-from doconnor@gsoft.com.au)
Received: from cain.gsoft.com.au (cain.gsoft.com.au [203.31.81.10])
	by mx1.freebsd.org (Postfix) with ESMTP id A52E28FC15;
	Tue, 19 Jun 2012 02:17:48 +0000 (UTC)
Received: from ur.gsoft.com.au (Ur.gsoft.com.au [203.31.81.55])
	(authenticated bits=0)
	by cain.gsoft.com.au (8.14.4/8.14.3) with ESMTP id q5J1sRUg000878
	(version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO);
	Tue, 19 Jun 2012 11:24:33 +0930 (CST)
	(envelope-from doconnor@gsoft.com.au)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: "Daniel O'Connor" <doconnor@gsoft.com.au>
In-Reply-To: <20120618093435.GA1017@gpr.nnz-home.ru>
Date: Tue, 19 Jun 2012 11:24:27 +0930
Content-Transfer-Encoding: quoted-printable
Message-Id: <68FBE843-7337-4C90-B01F-E0CAABB62BCD@gsoft.com.au>
References: <201206180754.q5I7sBoQ063448@svn.freebsd.org>
	<20120618093435.GA1017@gpr.nnz-home.ru>
To: Gennady Proskurin <gprspb@mail.ru>
X-Mailer: Apple Mail (2.1278)
X-Spam-Score: -2.51 () ALL_TRUSTED,BAYES_00,T_RP_MATCHES_RCVD
X-Scanned-By: MIMEDefang 2.67 on 203.31.81.10
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Poul-Henning Kamp <phk@freebsd.org>
Subject: Re: svn commit: r237223 - head/sys/dev/fb
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Jun 2012 02:17:50 -0000


On 18/06/2012, at 19:04, Gennady Proskurin wrote:
>> Modified: head/sys/dev/fb/fbreg.h
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/dev/fb/fbreg.h	Mon Jun 18 07:43:23 2012	=
(r237222)
>> +++ head/sys/dev/fb/fbreg.h	Mon Jun 18 07:54:10 2012	=
(r237223)
>> @@ -39,6 +39,7 @@
>> static __inline void
>> copyw(uint16_t *src, uint16_t *dst, size_t size)
>> {
>> +	size >>=3D 1;
>> 	while (size--)
>> 		*dst++ =3D *src++;
>> }
>=20
> If size is odd, this does not copy the last byte. Not sure, whether =
this is intended.

Add
KASSERT(size & 0x1 =3D=3D 0, ("odd size copy"));

before
size >>=3D 1;

:)

--
Daniel O'Connor software and network engineer
for Genesis Software - http://www.gsoft.com.au
"The nice thing about standards is that there
are so many of them to choose from."
  -- Andrew Tanenbaum
GPG Fingerprint - 5596 B766 97C0 0E94 4347 295E E593 DC20 7B3F CE8C