From owner-freebsd-current@FreeBSD.ORG Sat Jan 3 19:46:18 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8857E106566B for ; Sat, 3 Jan 2009 19:46:18 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtpout016.mac.com (asmtpout016.mac.com [17.148.16.91]) by mx1.freebsd.org (Postfix) with ESMTP id 72A468FC12 for ; Sat, 3 Jan 2009 19:46:18 +0000 (UTC) (envelope-from xcllnt@mac.com) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed; delsp=yes Received: from [192.168.1.96] (75-101-29-67.dsl.static.sonic.net [75.101.29.67]) by asmtp016.mac.com (Sun Java(tm) System Messaging Server 6.3-7.03 (built Aug 7 2008; 32bit)) with ESMTPSA id <0KCW00G68UX12V60@asmtp016.mac.com> for freebsd-current@freebsd.org; Sat, 03 Jan 2009 11:46:14 -0800 (PST) Message-id: <43883A46-9219-4B40-9175-137CFCD0E896@mac.com> From: Marcel Moolenaar To: "M. Warner Losh" In-reply-to: <20090103.111324.-98089972.imp@bsdimp.com> Date: Sat, 03 Jan 2009 11:46:13 -0800 References: <440945C2-252E-489A-902E-A499753A5EF8@mac.com> <20090103.104220.513891918.imp@bsdimp.com> <8F22F980-0D4C-4074-8685-3FFAD4558362@mac.com> <20090103.111324.-98089972.imp@bsdimp.com> X-Mailer: Apple Mail (2.930.3) Cc: bsam@ipt.ru, freebsd-current@freebsd.org, fbsdlist@src.cx Subject: Re: gjournal is not automounted any more X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Jan 2009 19:46:18 -0000 On Jan 3, 2009, at 10:13 AM, M. Warner Losh wrote: > : > But my problems are with a platform that has BSD labels, and not > GPT > : > labels, with a proper BSD label on the device. > : > : You don't have GEOM_BSD to service the DIOCGDINFO ioctl(2) > : anymore. We need to change fsck(8) so that it doesn't work > : only on BSD disk labels, but instead obtains the partition > : type (if applicable) in a more generic way so that it also > : applies to other partitioning schemes. > > Agreed. Do you have a proposal for how to do that? The best way to do it is to introduce a function that returns the file system name/type. It could be used by fsck(8), newfs(8), mount(8), etc to determine which variant to invoke. This function is best defined in libgeom, where it can get all the data it needs from the XML. geom_part puts it there anyway. Doing it in userland also makes it easier to actual read the partition and see if there's already a file system. It's one thing to use the partition type as a best guess, but lacking a partitioning scheme on the disk, it may be beneficial to pursue other avenues. Not to mention that it's better to return the actual file system that's there than some guess based on partition type. Thus: I'd like to eliminate the ioctl and do all or most of the work in user space. Thoughts? -- Marcel Moolenaar xcllnt@mac.com