Date: Tue, 24 Feb 2004 13:53:30 -0500 From: John Baldwin <jhb@FreeBSD.org> To: Erwin Lansing <erwin@FreeBSD.org> Cc: ports@FreeBSD.org Subject: Re: New ports need review Message-ID: <200402241353.30156.jhb@FreeBSD.org> In-Reply-To: <20040224184557.GB53766@droso.net> References: <200402241329.52709.jhb@FreeBSD.org> <20040224184557.GB53766@droso.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 24 February 2004 01:45 pm, Erwin Lansing wrote: > On Tue, Feb 24, 2004 at 01:29:52PM -0500, John Baldwin wrote: > > John, > > > I made a port for the monopd server that katlantik talks to. I also had > > to make a port for libmath++ (which it depends on). Both ports are very > > simple, but its been a while since I've done ports stuff and I'd > > appreciate review to make sure I haven't done things in some weird old > > fashioned way. The tarballs for each of the ports can be found at > > http://www.FreeBSD.org/~jhb/ports/ and include libmath++.tgz (to go in > > ports/math/) and monopd.tgz (to go in ports/games/). > > Looks good to me. Nothing obvious that jumps at me. No complaints from > portlint and (de)install/package works fine. If you didn't know about > devel/portlint, I can warmly recommend it, it catches many obvious and > even more non-obvious errors. I think I've heard of it before, but I could be thinking of manck. The last time I did a port we didn't have things like WITHOUT_FOO. :) Thanks for checking it though. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200402241353.30156.jhb>