Date: Wed, 30 Jul 2014 12:41:34 +0200 From: olli hauer <ohauer@gmx.de> To: marino@freebsd.org, Mathieu Arnold <mat@FreeBSD.org>, Max Brazhnikov <makc@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, William Grzybowski <wg@freebsd.org>, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r363361 - in head/editors/fte: . files Message-ID: <53D8CBDE.6050008@gmx.de> In-Reply-To: <53D8A2BB.7090704@marino.st> References: <201407291646.s6TGkjHH090335@svn.freebsd.org> <41D25BC1-AC62-4280-A342-8A2BDD84B1E0@adamw.org> <20140730070412.GA97692@FreeBSD.org> <3898057.T8DsoXnEEp@mercury.ph.man.ac.uk> <53D89EBF.4080805@marino.st> <2D24420529C9ECAEABB9A791@atuin.in.mat.cc> <53D8A2BB.7090704@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2014-07-30 09:46, John Marino wrote: > On 7/30/2014 09:37, Mathieu Arnold wrote: >> +--On 30 juillet 2014 09:29:03 +0200 John Marino >> <freebsd.contact@marino.st> wrote: >> | On 7/30/2014 09:25, Max Brazhnikov wrote: >> |> On Wed, 30 Jul 2014 07:04:13 +0000 Alexey Dokuchaev wrote: >> |>> On Tue, Jul 29, 2014 at 01:10:45PM -0400, Adam Weinberger wrote: >> |>>> I'm about to rename all patches that contain ::. Can we please stop >> |>>> producing patches with :: as a path separator, and use __ instead? >> |>> >> |>> Can we also stop using double underscore as it makes patch names so ugly >> |>> and unreadable that I have to spend twice as much time working on ports >> |>> that uses this stupid convention? >> |> >> |> It comes from the makepatch target. >> | >> | Makepatch name convention is no good. I was complaining about this (to >> | bapt) about the lack of a patch name convention and he said to propose >> | one. I've been meaning to do just that, but it also means fixing tools >> | like this. >> >> makepatch name convention is the convention, I find it pretty simple, and >> easy to remember, it does "s|/|__|" and that's all. Whatever the >> convention, there's always someone who will not like it, but it doesn't >> really matter, it's a convention so that everyone knows how to name patch >> files the same way. > > I disagree, there is no convention. Whoever created makepatch attempted > to create a defacto convention that most people don't like (as evidence > that patches not created by makepatch don't use it but rather the more > conventional* single underscore. I don't automatically recognize the > author of makepatch the authority. > > * As seen in other repos such as pkgsrc > > Take a vote. I'd bet the majority of people do not like "__" not just > "someone". I like the `make makepatch' convention, it is simple and you can get the path directly from the patch name without less/cat ... Using the `make makepatch* command has also the charm every patch follows at last a simple rule and you don't have to fiddle around with manual renaming, everyone is able to produce the same patch. About pkgsrc, I really don't care because the discussion is about FreeBSD standards that others can easily adopt and with `make makepatch' a simple standard and tool was added years ago. So I welcome the work that was done recently by adjusting the patch file name. -- olli
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53D8CBDE.6050008>