From owner-cvs-all@FreeBSD.ORG Sun Jan 3 07:06:19 2010 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D1867106566C; Sun, 3 Jan 2010 07:06:19 +0000 (UTC) (envelope-from marcus@marcuscom.com) Received: from creme-brulee.marcuscom.com (marcuscom-pt.tunnel.tserv1.fmt.ipv6.he.net [IPv6:2001:470:1f00:ffff::1279]) by mx1.freebsd.org (Postfix) with ESMTP id 6A6658FC17; Sun, 3 Jan 2010 07:06:19 +0000 (UTC) Received: from [IPv6:2001:470:1f00:2464::4] (shumai.marcuscom.com [IPv6:2001:470:1f00:2464::4]) by creme-brulee.marcuscom.com (8.14.3/8.14.3) with ESMTP id o0376v3R009169; Sun, 3 Jan 2010 02:06:57 -0500 (EST) (envelope-from marcus@marcuscom.com) From: Joe Marcus Clarke To: Doug Barton In-Reply-To: <4B402298.7040202@FreeBSD.org> References: <201001022211.o02MBMSn045154@repoman.freebsd.org> <4B402298.7040202@FreeBSD.org> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-Z6UwVQ9d4BiU5iDV06DX" Organization: MarcusCom, Inc. Date: Sun, 03 Jan 2010 02:06:25 -0500 Message-ID: <1262502385.16768.134.camel@shumai.marcuscom.com> Mime-Version: 1.0 X-Mailer: Evolution 2.28.2 FreeBSD GNOME Team Port X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,FH_DATE_PAST_20XX, NO_RELAYS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on creme-brulee.marcuscom.com Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/archivers/file-roller Makefile ports/archivers/file-roller/files patch-src_fr-command-zip.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Jan 2010 07:06:19 -0000 --=-Z6UwVQ9d4BiU5iDV06DX Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: quoted-printable On Sat, 2010-01-02 at 20:52 -0800, Doug Barton wrote: > Isn't this bass-ackwards? Is there some functionality from unzip that > this port needs that the version now in the base does not provide? If > that's the case, can someone make that issue known so that interested > parties can address it? There are two issues. The first is a lack of zipinfo. The unzip port includes the zipinfo binary which can be invoked via unzip by passing the -Z argument (i.e. unzip -Z is equivalent to calling zipinfo). The other major feature lacking in /usr/bin/unzip is password support. The unzip port supports password-encoded archives (via the -P argument), and the base version does not. If both of these issues get addressed, the base unzip would be fine. Without the fixes, file-roller is useless when it comes to zip archives. Joe >=20 > *scratching head* >=20 > Doug >=20 >=20 > Joe Marcus Clarke wrote: > > marcus 2010-01-02 22:11:22 UTC > >=20 > > FreeBSD ports repository > >=20 > > Modified files: > > archivers/file-roller Makefile=20 > > Added files: > > archivers/file-roller/files patch-src_fr-command-zip.c=20 > > Log: > > Now that -CURRENT has /usr/bin/unzip, explicitly invoke (and depend o= n) > > archivers/unzip. > > =20 > > Revision Changes Path > > 1.86 +6 -3 ports/archivers/file-roller/Makefile > > 1.1 +39 -0 ports/archivers/file-roller/files/patch-src_fr-c= ommand-zip.c (new) > >=20 > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/archivers/file-roller/Makef= ile.diff?&r1=3D1.85&r2=3D1.86&f=3Dh > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/archivers/file-roller/files= /patch-src_fr-command-zip.c > >=20 >=20 >=20 --=20 PGP Key : http://www.marcuscom.com/pgp.asc --=-Z6UwVQ9d4BiU5iDV06DX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEABECAAYFAktAQe8ACgkQb2iPiv4Uz4e69wCggO9fHBW5SitYdv5eIjl8J2tW nkoAn3mjQYiT8+Hna+C+X439asHl9UNW =gy7a -----END PGP SIGNATURE----- --=-Z6UwVQ9d4BiU5iDV06DX--