From owner-freebsd-bugs  Wed Sep 19  9:40: 8 2001
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 92C3737B408
	for <freebsd-bugs@hub.freebsd.org>; Wed, 19 Sep 2001 09:40:02 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.4/8.11.4) id f8JGe2a24625;
	Wed, 19 Sep 2001 09:40:02 -0700 (PDT)
	(envelope-from gnats)
Date: Wed, 19 Sep 2001 09:40:02 -0700 (PDT)
Message-Id: <200109191640.f8JGe2a24625@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
Cc: 
From: "Andrey Simonenko" <simon@comsys.ntu-kpi.kiev.ua>
Subject: Re: bin/30641: Patch for games/grdc
Reply-To: "Andrey Simonenko" <simon@comsys.ntu-kpi.kiev.ua>
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

The following reply was made to PR bin/30641; it has been noted by GNATS.

From: "Andrey Simonenko" <simon@comsys.ntu-kpi.kiev.ua>
To: "Ruslan Ermilov" <ru@FreeBSD.org>
Cc: <bug-followup@FreeBSD.org>
Subject: Re: bin/30641: Patch for games/grdc
Date: Wed, 19 Sep 2001 19:23:25 +0400

 ----- Original Message -----
 From: Ruslan Ermilov <ru@FreeBSD.org>
 To: Andrey Simonenko <simon@simon.org.ua>
 Cc: <bug-followup@FreeBSD.org>
 Sent: Wednesday, September 19, 2001 4:58 PM
 Subject: Re: bin/30641: Patch for games/grdc
 
 
 > On Tue, Sep 18, 2001 at 11:39:12AM +0300, Andrey Simonenko wrote:
 > >
 > > grdc(8) outputs big digital clock. Color of digits is red, if grdc(8)
 > > is used on b/w display, then it is hard to see something.
 > >
 > > This patch adds new flag to grdc(8): -b, which changes color of digits
 > > to b/w. Also arguments checking is improved.
 > >
 > Use the right (B/W) terminal type such as cons25-m.
 
 I don't know about it. Nevertheless given patch makes better arguments
 checking.
 
 >
 > > In this patch type of "sigtermed" variable is changed from "int" to
 > > "voilatile sig_atomic_t", because "sigtermed" variable is changed in
 signal
 > > handler.
 > >
 > This looks OK though a bit superflows in this case.  :-)
 > Also, is sig_atomic_t guaranteed to be a superset of int?
 > (I'm mostly concerned about the portability issues here,
 > I know that in FreeBSD sig_atomic_t is ether int or long.)
 
 I always use "volatile sig_atomic_t" type for variable, which can
 be changed in signal handlers. May be somebody another can
 help with answer about portability, I think that sig_atomic_t is correct
 type in this case.
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message