From owner-svn-ports-all@freebsd.org Sun May 6 15:44:09 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1C9DDFBDA02; Sun, 6 May 2018 15:44:09 +0000 (UTC) (envelope-from 01010163361fbfc6-24fd8a1b-0079-482d-8f4c-d7bb3a219639-000000@us-west-2.amazonses.com) Received: from a27-115.smtp-out.us-west-2.amazonses.com (a27-115.smtp-out.us-west-2.amazonses.com [54.240.27.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 68AC17598C; Sun, 6 May 2018 15:44:08 +0000 (UTC) (envelope-from 01010163361fbfc6-24fd8a1b-0079-482d-8f4c-d7bb3a219639-000000@us-west-2.amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=7v7vs6w47njt4pimodk5mmttbegzsi6n; d=amazonses.com; t=1525621440; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:In-Reply-To:Feedback-ID; bh=o8N8aQwv4ovACbMStOqXjIpsVOymuugwnIAMhCtbHns=; b=gkfFdCXj7HTDFbnGOgXdGlTtNnYq6vvpIyHGfMRIVi9oEZNzM+R/bVRfuZuYhL7+ KVE+bmJiiuvFz7JcHSlkqJ75vWlUfvXc8q7/QkwmCzrNvmyBI/j+0WY19HFWNppRwR4 AuTyX/pzr0sqly0kTPjgthNM2K+0VlAaZLacUZ+Y= Date: Sun, 6 May 2018 15:44:00 +0000 From: Koichiro Iwao To: Alexey Dokuchaev Cc: Adam Weinberger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <01010163361fbfc6-24fd8a1b-0079-482d-8f4c-d7bb3a219639-000000@us-west-2.amazonses.com> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <20180506151057.GA79630@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20180506151057.GA79630@FreeBSD.org> X-Operating-System: FreeBSD 11.2-PRERELEASE amd64 User-Agent: NeoMutt/20180323 X-SES-Outgoing: 2018.05.06-54.240.27.115 Feedback-ID: 1.us-west-2.ngRt4x2U/cWqug8pbfjwMxB6pcDw1fmN73bGmMLYyRI=:AmazonSES X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2018 15:44:09 -0000 On Sun, May 06, 2018 at 03:10:57PM +0000, Alexey Dokuchaev wrote: > On Sun, May 06, 2018 at 08:41:36AM -0600, Adam Weinberger wrote: > > Sorry, Alexey, but portlint was right here. @sample and other macros > > should *never* appear in PLIST_FILES. Even if the port installs only a > > single file, if it's a @sample, it goes in pkg-plist. > > Hmm, that's news to me; I'm pretty sure I've used @sample in PLIST_FILES, > verified generated package, and it came out as expected. I've also seen > others doing the same. Which is correct? As you say, it looks macros can be used in PLIST_FILES for me now. BTW, just let me say pkg bus error is not the reason why I switched to pkg-plist. I also thought macros shouldn't appear in PLIST_FILES when I made the commit. Thus I didn't mention about the pkg bug in the commit message at all. -- meta