From owner-freebsd-rc@FreeBSD.ORG Sat Oct 27 17:21:04 2012 Return-Path: Delivered-To: freebsd-rc@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 227D4B8B for ; Sat, 27 Oct 2012 17:21:04 +0000 (UTC) (envelope-from hrs@FreeBSD.org) Received: from mail.allbsd.org (gatekeeper.allbsd.org [IPv6:2001:2f0:104:e001::32]) by mx1.freebsd.org (Postfix) with ESMTP id 9465A8FC16 for ; Sat, 27 Oct 2012 17:21:03 +0000 (UTC) Received: from alph.allbsd.org (p1137-ipbf1505funabasi.chiba.ocn.ne.jp [118.7.212.137]) (authenticated bits=128) by mail.allbsd.org (8.14.5/8.14.5) with ESMTP id q9RHKl0T076556 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 28 Oct 2012 02:20:57 +0900 (JST) (envelope-from hrs@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) (authenticated bits=0) by alph.allbsd.org (8.14.5/8.14.5) with ESMTP id q9RHKjZs049917; Sun, 28 Oct 2012 02:20:46 +0900 (JST) (envelope-from hrs@FreeBSD.org) Date: Sun, 28 Oct 2012 02:17:52 +0900 (JST) Message-Id: <20121028.021752.529031225588915529.hrs@allbsd.org> To: utisoft@gmail.com Subject: Re: Spaces in ${name}_chroot From: Hiroki Sato In-Reply-To: References: X-PGPkey-fingerprint: BDB3 443F A5DD B3D0 A530 FFD7 4F2C D3D8 2793 CF2D X-Mailer: Mew version 6.5 on Emacs 23.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Virus-Scanned: clamav-milter 0.97.4 at gatekeeper.allbsd.org X-Virus-Status: Clean X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (mail.allbsd.org [133.31.130.32]); Sun, 28 Oct 2012 02:20:57 +0900 (JST) X-Spam-Status: No, score=-98.1 required=13.0 tests=CONTENT_TYPE_PRESENT, ONLY1HOPDIRECT,SAMEHELOBY2HOP,USER_IN_WHITELIST autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on gatekeeper.allbsd.org Cc: freebsd-rc@FreeBSD.org X-BeenThere: freebsd-rc@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Discussion related to /etc/rc.d design and implementation." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2012 17:21:04 -0000 Chris Rees wrote in : ut> Hi all, ut> ut> A guy in IRC pointed out to me that rc.subr will not work correctly if ut> a chroot has spaces in it. ut> ut> Although this is unlikely, would it hurt to include it? Lacking a src ut> bit someone may need to put their name to it, but I'm happy to commit ut> & handle MFCs. ut> ut> Chris ut> ut> [1] http://www.bayofrum.net/~crees/patches/rc-subr-support-chroot-spaces.diff I think this patch is correct. Please go ahead. -- Hiroki