Date: Tue, 01 Jun 2021 07:18:01 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 256301] bsd.port.mk: fix setting of FLAVOR in _FLAVOR_RECURSIVE_SH Message-ID: <bug-256301-7788-WwmFbQCXQf@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-256301-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-256301-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D256301 --- Comment #2 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3De70bedf4f71eda15307b550cefd028a= 5a4b0281a commit e70bedf4f71eda15307b550cefd028a5a4b0281a Author: Mathieu Arnold <mat@FreeBSD.org> AuthorDate: 2021-06-01 07:04:25 +0000 Commit: Mathieu Arnold <mat@FreeBSD.org> CommitDate: 2021-06-01 07:16:35 +0000 Mk/bsd.port.mk: Don't pass up an empty flavor. The classic way to handle flavors is to set: FLAVORS=3D foo bar FLAVOR?=3D ${FLAVORS:[0]} And in that case, FLAVOR is only set if the variable is not defined. If you pass an empty flavor using `FLAVOR=3D` then it remains empty after that line. It can leads to some ports with complicated logic to assume the wrong flavor is set. PR: 256301 Reported by: avg Differential Revision: https://reviews.freebsd.org/D30579 Mk/bsd.port.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-256301-7788-WwmFbQCXQf>