From owner-cvs-src@FreeBSD.ORG Thu Sep 25 19:43:59 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 31E24106568A for ; Thu, 25 Sep 2008 19:43:59 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: from mail-gx0-f17.google.com (mail-gx0-f17.google.com [209.85.217.17]) by mx1.freebsd.org (Postfix) with ESMTP id C28268FC0C for ; Thu, 25 Sep 2008 19:43:58 +0000 (UTC) (envelope-from nparhar@gmail.com) Received: by gxk10 with SMTP id 10so7472680gxk.19 for ; Thu, 25 Sep 2008 12:43:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:date:from:to:subject :message-id:mail-followup-to:references:mime-version:content-type :content-disposition:in-reply-to:user-agent; bh=EI5eHAYTqCpDavwf+QAHlTOpKBnPLav8T3IAh3ZU+D4=; b=AELQUcCpEAfyWbln1TtFC9fViq23cjKBCMKS5n6Yh8E8PhOgHeM0RUhl4tkp7QYQMp Xdm0BjdHNWqTNjcMlYZGdJzv9PebvWE9SS9cU93Pg/71CTgWXCC0tLuuqTCdMg2Iqm0t CUDPftn+W2MTXVgTAqwZSGhFxTmMwnLbAkabg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; b=HURZ2h18kVw7KhLdUv69rfXQxh0d0vNTT0ovhlEAhq4t4YZKLqeR5iOpUiQU41DpAd 7cz8Lro0wVE3PnoAunVoWp5J526uqykamaeWMturU4KB5t9gKHwfwHxWEC27qOIwGsor f08zhFn3IChazU0vhN36CkjFLs15xGMuUlymM= Received: by 10.142.169.4 with SMTP id r4mr87883wfe.63.1222371837538; Thu, 25 Sep 2008 12:43:57 -0700 (PDT) Received: from insightsol.com ( [67.100.74.36]) by mx.google.com with ESMTPS id 30sm1984353wfg.9.2008.09.25.12.43.49 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 25 Sep 2008 12:43:50 -0700 (PDT) Date: Thu, 25 Sep 2008 12:43:46 -0700 From: Navdeep Parhar To: cvs-src@freebsd.org Message-ID: <20080925194346.GA20498@insightsol.com> Mail-Followup-To: cvs-src@freebsd.org References: <200809251932.m8PJWJxr073365@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200809251932.m8PJWJxr073365@repoman.freebsd.org> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Subject: Re: cvs commit: src/gnu/usr.bin/gdb/kgdb kld.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2008 19:43:59 -0000 On Thu, Sep 25, 2008 at 07:32:03PM +0000, John Baldwin wrote: > jhb 2008-09-25 19:32:03 UTC > > FreeBSD src repository > > Modified files: > gnu/usr.bin/gdb/kgdb kld.c > Log: > SVN rev 183359 on 2008-09-25 19:32:03Z by jhb > > Use existing GDB routines for parsing the section table of klds in > the 'add-kld' command instead of doing it more by hand. > > MFC after: 1 week > > Revision Changes Path > 1.10 +23 -36 src/gnu/usr.bin/gdb/kgdb/kld.c This can lead to a bad free + core dump as I'd mentioned here: http://lists.freebsd.org/pipermail/freebsd-hackers/2008-September/026024.html Please initialize sections and sections_end to NULL. 205c204,205 < struct section_table *sections, *sections_end, *s; --- > struct section_table *sections = NULL, *sections_end = NULL, *s; Regards, Navdeep