Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 8 Dec 2019 01:47:29 +0000 (UTC)
From:      Jeff Roberson <jeff@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r355514 - head/sys/vm
Message-ID:  <201912080147.xB81lTHD022023@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jeff
Date: Sun Dec  8 01:47:29 2019
New Revision: 355514
URL: https://svnweb.freebsd.org/changeset/base/355514

Log:
  Do not assert that the object lock is held in vm_object_set_writeable_dirty.
  A valid reference is all that is required.  If we race with a deallocation
  we will harmlessly misidentify the type of an already dead object.
  
  Reviewed by:	kib, markj
  Differential Revision:	https://reviews.freebsd.org/D22636

Modified:
  head/sys/vm/vm_object.c

Modified: head/sys/vm/vm_object.c
==============================================================================
--- head/sys/vm/vm_object.c	Sun Dec  8 01:20:37 2019	(r355513)
+++ head/sys/vm/vm_object.c	Sun Dec  8 01:47:29 2019	(r355514)
@@ -2225,8 +2225,6 @@ void
 vm_object_set_writeable_dirty(vm_object_t object)
 {
 
-	VM_OBJECT_ASSERT_LOCKED(object);
-
 	/* Only set for vnodes & tmpfs */
 	if (object->type != OBJT_VNODE &&
 	    (object->flags & OBJ_TMPFS_NODE) == 0)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201912080147.xB81lTHD022023>