Date: Mon, 29 Aug 2022 12:27:55 -0600 From: Warner Losh <imp@bsdimp.com> To: Mark Johnston <markj@freebsd.org> Cc: Alexander Motin <mav@freebsd.org>, Matthew Grooms <mgrooms@shrew.net>, FreeBSD-STABLE Mailing List <freebsd-stable@freebsd.org> Subject: Re: CAM IOCTL issue with 13.1-STABLE Message-ID: <CANCZdfrJ1S8=F_YJt_R4oJY2q5eyqbVopbG6wThVehtLrLON-w@mail.gmail.com> In-Reply-To: <Ywz%2BvA4Ls6to3XHz@nuc> References: <c1575141-ebc2-ece1-db23-7d50e6bac6db@shrew.net> <3caeafa8-6c9c-2632-9010-9c8e21098378@FreeBSD.org> <Ywz%2BvA4Ls6to3XHz@nuc>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Mon, Aug 29, 2022 at 12:00 PM Mark Johnston <markj@freebsd.org> wrote: > On Tue, Aug 23, 2022 at 09:44:48AM -0400, Alexander Motin wrote: > > Hi Matthew, > > > > I took a brief look on it and found that CAM compatibility code just > > does not cover that IOCTL. That is why when CAM version was bumped it > > cause the unexpected breakage. Short term fix would be to rebuild the > > application to new CAM version, while for proper fix somebody would have > > to implement the compatibility code for that IOCTL. > > I looked at this a bit more, and it seems trivial since > 1) for periph drivers, CAMGETPASSTHRU ignores the input CCB, and > 2) the CAM version bump from 0x19 to 0x1a does not affect XPT_GDEVLIST > CCBs. > > Note for instance that cam_compat_handle_0x19() is a no-op for > CAMGETPASSTHRU. So, isn't the patch here sufficient? > https://reviews.freebsd.org/D36389 I believe the above patch should just work. I don't know if we need to structure it differently. I don't think so, though... Warner > On 22.08.2022 14:48, Matthew Grooms wrote: > > > There appears to be a problem with XPT_DEV_MATCH CAM IOCTL calls. This > > > prevents a bunch of packages on 13.1-STABLE from working correctly. A > > > bug was filed and Mark J was kind enough to help diagnose the issue, > but > > > it's sitting in unassigned status. Can someone please assign it to the > > > correct group so it gets some attention? > > > > > > The FreeBSD bug: > > > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264709 > > > > > > The offending commit ( I think? ): > > > > https://cgit.freebsd.org/src/commit/sys/cam/cam_ccb.h?h=stable/13&id=7d7168478380f08b3a7fd58ca7cf83182fae6850 > > > > -- > > Alexander Motin > > > > [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Aug 29, 2022 at 12:00 PM Mark Johnston <<a href="mailto:markj@freebsd.org">markj@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Aug 23, 2022 at 09:44:48AM -0400, Alexander Motin wrote:<br> > Hi Matthew,<br> > <br> > I took a brief look on it and found that CAM compatibility code just <br> > does not cover that IOCTL. That is why when CAM version was bumped it <br> > cause the unexpected breakage. Short term fix would be to rebuild the <br> > application to new CAM version, while for proper fix somebody would have <br> > to implement the compatibility code for that IOCTL.<br> <br> I looked at this a bit more, and it seems trivial since<br> 1) for periph drivers, CAMGETPASSTHRU ignores the input CCB, and<br> 2) the CAM version bump from 0x19 to 0x1a does not affect XPT_GDEVLIST<br> CCBs.<br> <br> Note for instance that cam_compat_handle_0x19() is a no-op for<br> CAMGETPASSTHRU. So, isn't the patch here sufficient?<br> <a href="https://reviews.freebsd.org/D36389" rel="noreferrer" target="_blank">https://reviews.freebsd.org/D36389</a></blockquote><div><br></div><div>I believe the above patch should just work. I don't know if we need to structure it</div><div>differently. I don't think so, though...</div><div><br></div><div>Warner</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"> > On 22.08.2022 14:48, Matthew Grooms wrote:<br> > > There appears to be a problem with XPT_DEV_MATCH CAM IOCTL calls. This <br> > > prevents a bunch of packages on 13.1-STABLE from working correctly. A <br> > > bug was filed and Mark J was kind enough to help diagnose the issue, but <br> > > it's sitting in unassigned status. Can someone please assign it to the <br> > > correct group so it gets some attention?<br> > > <br> > > The FreeBSD bug:<br> > > <a href="https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264709" rel="noreferrer" target="_blank">https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=264709</a><br>; > > <br> > > The offending commit ( I think? ):<br> > > <a href="https://cgit.freebsd.org/src/commit/sys/cam/cam_ccb.h?h=stable/13&id=7d7168478380f08b3a7fd58ca7cf83182fae6850" rel="noreferrer" target="_blank">https://cgit.freebsd.org/src/commit/sys/cam/cam_ccb.h?h=stable/13&id=7d7168478380f08b3a7fd58ca7cf83182fae6850</a>; <br> > <br> > -- <br> > Alexander Motin<br> > <br> <br> </blockquote></div></div>home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfrJ1S8=F_YJt_R4oJY2q5eyqbVopbG6wThVehtLrLON-w>