From nobody Sun Apr 27 14:26:13 2025 X-Original-To: current@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZlpmC3YKXz5tvQX for ; Sun, 27 Apr 2025 14:26:19 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZlpmB1Rrnz40ND; Sun, 27 Apr 2025 14:26:18 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=UFj+2xnz; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=freebsd.org (policy=none); spf=pass (mx1.freebsd.org: domain of markjdb@gmail.com designates 2607:f8b0:4864:20::82b as permitted sender) smtp.mailfrom=markjdb@gmail.com Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-47692b9d059so73519701cf.3; Sun, 27 Apr 2025 07:26:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745763976; x=1746368776; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=o6B1uoATUg+QytFpdUhm+vjHd0Da0O5DRdhEtkBm2Wg=; b=UFj+2xnzeMkjBV5rhFaz1pk15KhUKNOugc9Dv+BRUk9MbwyeXS76S8fkFbXATPQ8zu zSSwdAAEw5DMH23/JHBdkkxH83GlwDicGNw0kbHeZeI6rAggJrQFkO0AS/icALL07X+z sUh7yuvM/Q6ASUy60LxOO/PLIIqRpnUVTNsVVFd9tSyDCmgyA1gIGCJS0GoUj+652Z9g tKiccZ6qmMpiCsmdHpAMwTTwIRLL+tXpkWi5zWy3ARgFxatupPlK4Nazt2l0pGZntBAw VZFA1Af1/mzDUzoO2kOuxOGOsrNsjLb9JHW0dXm6IjbV/8LkAtXsVA5O714qTBFsKhOp Y1/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745763976; x=1746368776; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6B1uoATUg+QytFpdUhm+vjHd0Da0O5DRdhEtkBm2Wg=; b=jdt5hV+pK3Q1AMbEpI9fBRVw5vu3jKL4FiyQI37MgzTpOgZ40VOwywKNNPJQk3u/RB kmBYcjueqR2nkNXVqsVcCrojsH1qfI6ii0N4MHpds7ogkdCAfhtqEiYv3nnHV5cH8gKF hMZe5iKBK9t0A04P5dTXjub3L3WjZ6PVBXpUCzK4OfPMQldFENAE1sG1SRkTuWX2aa3g 00niqy8i0ZonBl2fVNus4/Z+C3m+qybbQeBiDAmzHT+9mPlU7OxQlJn+JsUleUky5DUD LJHvutcP1ROgOEj6kDUm/cHEHwlRccXhjJy6UrRcmo1Uwrsw9hSzUrIhWExWZB6tMoUv C4jQ== X-Forwarded-Encrypted: i=1; AJvYcCVr3SLwBPq0gO+w68A1sZr7GeS2onmwDe7GbM9EGdq2Ga4gmqS/tUUfpyhqaorFR5UyN3gGjFwM@freebsd.org X-Gm-Message-State: AOJu0YzTNt+/NG0hMyEtRlUW+tHwVPgyG9Q1hRnMzVf+j1NWx9KY3RX5 dTFV0K7giIeO4sokEMUgh63gtolmc6JO4Gd+cHvr/rDXyB6nrmWKFUGeM/er X-Gm-Gg: ASbGnctRaB8UzYT95nIupIt/k8xBwZ8h9cLvWd/hzlxbW93CmGb6rB6AOo0vlO+5dZJ iouRz9VjF7vPKbh7EP66R1Eum/jReZZLCXOdr3fb4vyPKUs85dm28ixQ5IMbV2xc4E74nAjuIm9 ENh7oQ5LrW8v5gL7jemOsFwGtNWu1EesSROSuqMpKDnAoavTP01K0H3lwJHfQlnMKiE61WqVSz8 Qj6cuM+btSH1jQtSiqcUf4bf1C5gphlmcZhB9NQkKJIemubxVxFVZEc8qBnj8HKSPCv4WmVeg0+ kg5sr0LsjtJFn+n1WRj01fbFTp+M8JpzmBxGB2zWYRsLcyn5I3hn2yE= X-Google-Smtp-Source: AGHT+IFmk+97cZi2wChF6hudKeMmRhRbMCsYz4s5jcvo9xwWiTfYW1hNV58FggoO2Ri+CKfacA/GRw== X-Received: by 2002:a05:622a:3cc:b0:477:4df:9a58 with SMTP id d75a77b69052e-48131903d5dmr100440541cf.18.1745763976216; Sun, 27 Apr 2025 07:26:16 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47ea1794482sm50036181cf.56.2025.04.27.07.26.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Apr 2025 07:26:15 -0700 (PDT) Date: Sun, 27 Apr 2025 10:26:13 -0400 From: Mark Johnston To: Andriy Gapon Cc: Konstantin Belousov , FreeBSD Current Subject: Re: RTLD_DEEPBIND question Message-ID: References: <0b3dda4e-53e4-40e5-9484-8b5ffb84e658@FreeBSD.org> <900c8521-559a-47b5-acaa-ae941f6852c4@freebsd.org> <7c4e1682-d797-493c-8326-08d51dde3359@FreeBSD.org> <59db8ace-770f-4f73-976f-411f6de0885a@FreeBSD.org> List-Id: Discussions about the use of FreeBSD-current List-Archive: https://lists.freebsd.org/archives/freebsd-current List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-current@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <59db8ace-770f-4f73-976f-411f6de0885a@FreeBSD.org> X-Spamd-Result: default: False [2.74 / 15.00]; NEURAL_SPAM_LONG(1.00)[1.000]; NEURAL_SPAM_MEDIUM(0.68)[0.683]; NEURAL_SPAM_SHORT(0.65)[0.653]; MID_RHS_NOT_FQDN(0.50)[]; FORGED_SENDER(0.30)[markj@freebsd.org,markjdb@gmail.com]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; MIME_GOOD(-0.10)[text/plain]; DMARC_POLICY_SOFTFAIL(0.10)[freebsd.org : SPF not aligned (relaxed), DKIM not aligned (relaxed),none]; TO_DN_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_TLS_LAST(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,freebsd.org]; DKIM_TRACE(0.00)[gmail.com:+]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_SOME(0.00)[]; FROM_NEQ_ENVFROM(0.00)[markj@freebsd.org,markjdb@gmail.com]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::82b:from]; MLMMJ_DEST(0.00)[current@freebsd.org]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; MISSING_XM_UA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com] X-Rspamd-Queue-Id: 4ZlpmB1Rrnz40ND X-Spamd-Bar: ++ On Thu, Apr 24, 2025 at 08:56:44AM +0300, Andriy Gapon wrote: > On 23/04/2025 21:56, Andriy Gapon wrote: > > BTW, I've been wondering how illumos avoids the problem even though they > > do not use any special dlopen flags. > > It turns out that they link almost all system shared libraries with > > -Bdirect option (which is Solaris/illumos specific). > > It's somewhat similar to, but different from, -Bsymbolic. > > https://docs.oracle.com/cd/E23824_01/html/819-0690/aehzq.html#scrolltoc > > https://docs.oracle.com/cd/E36784_01/html/E36857/gejfe.html > > Oh, and it looks like there is an even better explanation for illumos. > There is a version map file for libdtrace which explicitly lists API > functions and makes everything else local. > https://github.com/illumos/illumos-gate/blob/master/usr/src/lib/libdtrace/common/mapfile-vers > > I wonder why we didn't do the same when porting. > Maybe we should do that now? I don't have any objection, but I believe adding a version map after the fact doesn't accomplish much, assuming that we care deeply about ABI stability in libdtrace.so (I'm not sure we do though). > > I think that on FreeBSD we should use symbol visibility attributes or a > > symbol map to hide (make local) symbols that are not expected to be > > interposed or have a high chance to be interposed by accident. > > > > IMO, yyparse should definitely get that treatment. > > > > I think that approach would be better than magic rtld tricks. > > Especially because the tricks do not work with the current rtld. > > I'd rather make a change to libdtrace.so than to rtld. > > This, while not as nice as the illumos solution, fixes my specific issue: > diff --git a/cddl/lib/libdtrace/Makefile b/cddl/lib/libdtrace/Makefile > index d086fffb07bc..58054d129b49 100644 > --- a/cddl/lib/libdtrace/Makefile > +++ b/cddl/lib/libdtrace/Makefile > @@ -146,7 +146,8 @@ CFLAGS+= -fsanitize=address -fsanitize=undefined > LDFLAGS+= -fsanitize=address -fsanitize=undefined > .endif > > -LIBADD= ctf elf proc pthread rtld_db xo > +VERSION_MAP= ${.CURDIR}/Symbol.map > +LIBADD= ctf elf proc pthread rtld_db xo > > CLEANFILES= dt_errtags.c dt_names.c > > diff --git a/cddl/lib/libdtrace/Symbol.map b/cddl/lib/libdtrace/Symbol.map > new file mode 100644 > index 000000000000..89ee9de65209 > --- /dev/null > +++ b/cddl/lib/libdtrace/Symbol.map > @@ -0,0 +1,4 @@ > +{ > + local: > + yy*; > +}; This just gives the lexer/parser symbols in libdtrace.so local visibility? I think that's fine.