From owner-svn-src-projects@FreeBSD.ORG Thu Jan 22 07:25:51 2009 Return-Path: Delivered-To: svn-src-projects@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A84261065677 for ; Thu, 22 Jan 2009 07:25:51 +0000 (UTC) (envelope-from pho@holm.cc) Received: from relay01.pair.com (relay01.pair.com [209.68.5.15]) by mx1.freebsd.org (Postfix) with SMTP id 49EBC8FC13 for ; Thu, 22 Jan 2009 07:25:50 +0000 (UTC) (envelope-from pho@holm.cc) Received: (qmail 58726 invoked from network); 22 Jan 2009 06:59:09 -0000 Received: from 87.58.145.190 (HELO x2.osted.lan) (87.58.145.190) by relay01.pair.com with SMTP; 22 Jan 2009 06:59:09 -0000 X-pair-Authenticated: 87.58.145.190 Received: from x2.osted.lan (localhost.osted.lan [127.0.0.1]) by x2.osted.lan (8.14.2/8.14.2) with ESMTP id n0M6x8Ot096868; Thu, 22 Jan 2009 07:59:08 +0100 (CET) (envelope-from pho@x2.osted.lan) Received: (from pho@localhost) by x2.osted.lan (8.14.2/8.14.2/Submit) id n0M6x8Bs096867; Thu, 22 Jan 2009 07:59:08 +0100 (CET) (envelope-from pho) Date: Thu, 22 Jan 2009 07:59:08 +0100 From: Peter Holm To: Roman Divacky Message-ID: <20090122065908.GA96726@x2.osted.lan> References: <200901212124.n0LLOaFB091737@svn.freebsd.org> <20090121221258.GA52915@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090121221258.GA52915@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: svn-src-projects@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r187571 - projects/stress2/lib X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2009 07:25:52 -0000 On Wed, Jan 21, 2009 at 11:12:58PM +0100, Roman Divacky wrote: > On Wed, Jan 21, 2009 at 09:24:36PM +0000, Peter Holm wrote: > > Author: pho > > Date: Wed Jan 21 21:24:36 2009 > > New Revision: 187571 > > URL: http://svn.freebsd.org/changeset/base/187571 > > > > Log: > > Attempt to ensure that setup() is called before any system load. > > > > Approved by: kib > > > > Modified: > > projects/stress2/lib/main.c > > > > Modified: projects/stress2/lib/main.c > > ============================================================================== > > --- projects/stress2/lib/main.c Wed Jan 21 21:01:02 2009 (r187570) > > +++ projects/stress2/lib/main.c Wed Jan 21 21:24:36 2009 (r187571) > > @@ -106,10 +106,9 @@ run_tests(int i) > > signal(SIGHUP, run_test_handler); > > signal(SIGINT, exit_handler); > > atexit(callcleanup); > > - arc4random_stir(); > > + setup(i); > > if ((strcmp(getprogname(), "run") != 0) && (op->nodelay == 0)) > > sleep(random_int(1,10)); > > - setup(i); > > start = time(NULL); > > while (done_testing == 0 && > > (time(NULL) - start) < op->run_time) { > > are you sure you want to get rid of the arc4random_stir() ? No, but to quote the man page: There is no need to call arc4random_stir() before using arc4random(), since arc4random() automatically initializes itself. Is that wrong? - Peter