From owner-freebsd-current@freebsd.org Fri May 14 16:03:22 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B662064CD2D for ; Fri, 14 May 2021 16:03:22 +0000 (UTC) (envelope-from marc@bumblingdork.com) Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FhYGd5bQVz4WZS for ; Fri, 14 May 2021 16:03:21 +0000 (UTC) (envelope-from marc@bumblingdork.com) Received: by mail-ej1-x62b.google.com with SMTP id n2so45334698ejy.7 for ; Fri, 14 May 2021 09:03:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bumblingdork.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mBaCoL4MrOatxYU78YqyaSr7P/mHMoHzRn2uRUO84ww=; b=AcB9piHgb8XtAcsq7n19Gl5CJneX7k6OmHCVkrJYe+dVA2y/KOqIzdLp2y1lwyMgkc clu52Pt6ZjW+xjJPWCXZEH41SPghC5PoLk+3bAGpgORSzhyPc9ddHxHKYtpH6AGICSNV S0pdlJBXgZ+fkFxtx90woK3L/xQadK66pcs5i+TjRqydueCrOubH6pLjhzqxJXhJOHFZ Ngfn/3n5nnMLMozOpCR0klF43PSuoo59TkMyaGwxdj+AwTGyj3zt0GNWdMHZlw5k5f40 R0uSXjySo38Jg0bUteLL95dFY7wyRe423t7oAFtzQNSTBoj1nmJUMtzfREvx6uvyGJRZ f59w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=mBaCoL4MrOatxYU78YqyaSr7P/mHMoHzRn2uRUO84ww=; b=DeYoVjfqAOh1B0QWDLA4AkHVX2cGVZ/TZsdmlwcORYBTFFujMUJXMU5U07PIOQUaCO oFdV1beJSRtYiEc5Xs7MXzcXQhus72iwXmRc/z2GVlLDVcGcGnz02lA+K4n274ki+iQ/ Bd7JjexY19zfGhXaozsVbE6FzOMFbMzSmP3Tkvto3jiYonkos01as9eMrz8hJoS46yWf ZuHMUP6KgxirfS99rncaJgbqgx9Pnk8BooregYj1ifmXYKsyUXTkO7MM5zWykaRRpl56 Hltmjtr2m7wEnUy8B9wjMoQ7+xljr6qtX3gwvmnBKYnGFaKhxTaie7MBoJbuK6tiyCb1 O18g== X-Gm-Message-State: AOAM533LJAtqu8XZbxi2DNg7GR8zAtAbQy/51LB/qShBx2k+HSili3Nv xx8+GbCbzpcItxN/4lFlzqbdTQ== X-Google-Smtp-Source: ABdhPJykSl+M4dNU0Ng95UJowgNGvpQIIrmhRK9rR1LTVCe0839BnjoZ7edZUv01It3Yw0Fz5nsIJA== X-Received: by 2002:a17:906:e88:: with SMTP id p8mr49910279ejf.31.1621008200163; Fri, 14 May 2021 09:03:20 -0700 (PDT) Received: from smtpclient.apple ([2001:981:3350:1:d60:c3f0:bfdb:1f82]) by smtp.gmail.com with ESMTPSA id a22sm4940471edu.14.2021.05.14.09.03.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 14 May 2021 09:03:19 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.80.0.2.43\)) Subject: Re: CURRENT crashes at early boot on Lenovo T540p: rtsx to blame - 13.0-RELEASE crashes same way! From: Marc Veldman In-Reply-To: Date: Fri, 14 May 2021 18:03:18 +0200 Cc: freebsd-current@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <8d2be5f2-4144-082e-4237-0dac0c4b37e6@restart.be> <6798878a-c499-d78d-e96d-d744513cb80d@restart.be> <1de588e2-20cb-3206-3aea-f3f88f577675@restart.be> <67f0874a-6a05-67f1-3f2b-c4b3dc67fa11@FreeBSD.org> <83b823bf-c6c2-2f6a-b5dd-2e91b4d1931e@restart.be> <2c208bbc-5adc-2327-4717-a5e7c8d64b4b@FreeBSD.org> <9a15daa7-2b17-e257-d4d1-850c632a9db8@restart.be> <417a97b9-2c40-310c-c445-b193c493b880@FreeBSD.org> <7eb763ce-0bbf-9baf-2ede-968ee25cff2e@restart.be> <0CA59364-6802-4733-962A-3EEB00B43AFE@bumblingdork.com> <20210514144830.6b19de85@ernst.home> <51290711-0DC5-45DD-B2DB-4C2D98667DC7@bumblingdork.com> To: Henri Hennebert X-Mailer: Apple Mail (2.3654.80.0.2.43) X-Rspamd-Queue-Id: 4FhYGd5bQVz4WZS X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bumblingdork.com header.s=google header.b=AcB9piHg; dmarc=pass (policy=none) header.from=bumblingdork.com; spf=pass (mx1.freebsd.org: domain of marc@bumblingdork.com designates 2a00:1450:4864:20::62b as permitted sender) smtp.mailfrom=marc@bumblingdork.com X-Spamd-Result: default: False [-3.50 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[bumblingdork.com:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[bumblingdork.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; SUBJECT_ENDS_EXCLAIM(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::62b:from]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[bumblingdork.com:s=google]; FREEFALL_USER(0.00)[marc]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::62b:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::62b:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[freebsd-current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 May 2021 16:03:22 -0000 > On 14 May 2021, at 17:29, Henri Hennebert wrote: >=20 > On 5/14/21 5:05 PM, Marc Veldman wrote: >>> On 14 May 2021, at 16:48, Gary Jennejohn = wrote: >>>=20 >>> On Fri, 14 May 2021 16:21:05 +0200 >>> Marc Veldman wrote: >>>=20 >>>>> On 14 May 2021, at 10:22, Henri Hennebert wrote: >>>>>=20 >>>>>=20 >>>>> Please test the 2.0h version from GitHub. >>>>>=20 >>>>=20 >>>> On my Lenovo P50s: >>>>=20 >>>> Cold boot with card not inserted: OK >>>> Insert card after boot, no crash, but the message >>>> seems weird: >>>>=20 >>>> May 14 16:01:27 supernovo kernel: rtsx0: Interrupt card = inserted/removed >>>> May 14 16:01:27 supernovo kernel: rtsx0: Card absent >>>> May 14 16:01:27 supernovo kernel: mmc0: detached >>>>=20 >>>> Cold boot with card inserted: OK >>>> Remove card after boot, no crash, but the message >>>> seems weird: >>>>=20 >>>> May 14 16:06:08 supernovo kernel: rtsx0: Interrupt card = inserted/removed >>>> May 14 16:06:08 supernovo kernel: rtsx0: Card present >>>> May 14 16:06:08 supernovo kernel: mmc0: on rtsx0 >>>>=20 >>>> I have the inversion flag turned on /boot/loader.conf >>>>=20 >>>> dev.rtsx.0.inversion=3D1 >>>> dev.rtsx.0.debug=3D1 >>>>=20 >>>=20 >>> This is weird because the man page states that the inversion flag is >>> required with the P50. >>>=20 >>> BTW Henri, if you're reading this, there's a bug in exactly this = part >>> of the man page: sovled rather than solved >=20 > Thank you for the hint - will be corrected in the next push. >=20 >>>=20 >>> But, the trace output indicates that you do not need the inversion = flag. >>>=20 >>> Maybe your P50 (may be a later model than the P50s tested during = driver >>> development) does not have the problem. >> I removed the flag, and it works now.Thanks! >> What is it in the trace that indicated that the inversion flag is not = needed? >=20 > In Bug 255130 they ask me to automate the inversion. I do it for the = P50s and T470p following informations from Bug 204521. >=20 > But strangely it is not applicable to this particular P50s. So, as = indicated in my previous mail, it must be nullify with = dev.rtsx.0.inversion=3D0. >=20 > To investigate this last problem can you send >=20 > kenv | grep smbios.system marc@supernovo:~ $ kenv | grep smbios.system smbios.system.family=3D"ThinkPad P50s" smbios.system.maker=3D"LENOVO" smbios.system.product=3D"20FLCTO1WW" smbios.system.serial=3D"R90N30VP" smbios.system.sku=3D"LENOVO_MT_20FL_BU_Think_FM_ThinkPad P50s" smbios.system.uuid=3D"cbc5ee4c-2b18-11b2-a85c-a62da394388c" smbios.system.version=3D"ThinkPad P50s" marc@supernovo:~ $ >=20 > and >=20 > dmesg|grep rtsx >=20 rtsx0: <2.0h Realtek RTS522A PCI MMC/SD Card Reader> mem = 0xf4100000-0xf4100fff at device 0.0 on pci1 rtsx0: Inversion activated for LENOVO/ThinkPad P50s/20FLCTO1WW, see BUG = in rtsx(4) rtsx0: If a card is detected without an SD card present, add = dev.rtsx.0.inversion=3D0 in loader.conf(5) rtsx0: We are running with inversion: 0 rtsx0: Interrupt card inserted/removed rtsx0: Card present rtsx0: A card is detected mmc0: on rtsx0 rtsx0: Interrupt card inserted/removed rtsx0: Card absent rtsx0: Interrupt card inserted/removed rtsx0: Card present mmc0: on rtsx0 rtsx0: Interrupt card inserted/removed rtsx0: Card absent Best regards, Marc Veldman=