Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Mar 2024 21:07:43 +0100
From:      Daniel Engberg <daniel.engberg.lists@pyret.net>
To:        Yuri Victorovich <yuri@FreeBSD.org>
Cc:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   Re: git: ffac4f7ebb89 - main - science/nwchem: Fix extremely  slow build time due to gmake-4.4.1 issues
Message-ID:  <695bdddc5b6a97e03954704e1af3b84c@mail.infomaniak.com>
In-Reply-To: <202403291936.42TJaTNA021007@gitrepo.freebsd.org>
References:  <202403291936.42TJaTNA021007@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2024-03-29T20:36:29.000+01:00, Yuri Victorovich <yuri@FreeBSD.org> wrote=
:
>  The branch main has been updated by yuri:
>=20
> URL: https://cgit.FreeBSD.org/ports/commit/?id=3Dffac4f7ebb89f9ecd885d633=
a5a860254040257c
>=20
> commit ffac4f7ebb89f9ecd885d633a5a860254040257c
> Author:     Yuri Victorovich <yuri@FreeBSD.org>
> AuthorDate: 2024-03-29 19:33:36 +0000
> Commit:     Yuri Victorovich <yuri@FreeBSD.org>
> CommitDate: 2024-03-29 19:36:23 +0000
>=20
>     science/nwchem: Fix extremely slow build time due to gmake-4.4.1 issu=
es
>    =20
>     Switched back to gmake-4.3
> ---
>  science/nwchem/Makefile | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/science/nwchem/Makefile b/science/nwchem/Makefile
> index b1b6bbeea975..639b8987e8ac 100644
> --- a/science/nwchem/Makefile
> +++ b/science/nwchem/Makefile
> @@ -30,9 +30,14 @@ LIB_DEPENDS=3D=09libblas.so:math/blas \
>  RUN_DEPENDS=3D=09nwchem-data>0:science/nwchem-data
>  TEST_DEPENDS=3D=09bash:shells/bash
> =20
> -USES=3D=09=09fortran gettext-runtime gmake perl5 pkgconfig
> +USES=3D=09=09fortran gettext-runtime perl5 pkgconfig # gmake is temporar=
ily removed, see https://savannah.gnu.org/bugs/?65533
>  USE_PERL5=3D=09build
> =20
> +# use gmake-4.3, see https://savannah.gnu.org/bugs/?65533
> +BUILD_DEPENDS+=3D=09gmake43>0:devel/gmake43
> +CONFIGURE_ENV+=3D=09MAKE=3Dgmake
> +MAKE_CMD=3D=09gmake
> +
>  USE_GITHUB=3D=09yes
 GH_ACCOUNT=3D=09nwchemgit

Hi,

With all due respect this is not how we should solve edge cases. While nwch=
em has been slow to build for a few days you reported to upstream (both gma=
ke and nwchem) only a few hours ago [1]. There's also a newer version of nw=
chem available [2], this should've preferably been the first thing to test =
even if it's unlikely to fix the issue in this case. Even so, why the rush?=
 The commit message for adding back gmake 4.3 does not mention anything abo=
ut contacting the maintainer. Please refrain from committing ports on behal=
f of others without their consent. Wait for the maintainer to get back to y=
ou and if it's an emergency use a local tree or overlays in Poudriere tempo=
rarily while people are trying to work out the issue and a potential soluti=
on.

1: https://github.com/nwchemgit/nwchem/issues/959
https://savannah.gnu.org/bugs/?65533
2: https://github.com/nwchemgit/nwchem/releases/tag/v7.2.2-release

Best regards,
Daniel (diizzy@)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?695bdddc5b6a97e03954704e1af3b84c>