From owner-freebsd-ports@FreeBSD.ORG Thu May 19 09:12:02 2005 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 40B2516A4CE; Thu, 19 May 2005 09:12:02 +0000 (GMT) Received: from voruta.vu.lt (mail.vu.lt [193.219.80.13]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0A7C843DB8; Thu, 19 May 2005 09:12:01 +0000 (GMT) (envelope-from Rolandas.Naujikas@mif.vu.lt) Received: from [192.168.42.55] (nat1.mif.vu.lt [193.219.42.9]) by voruta.vu.lt (VU20031031) with ESMTP id j4J9BwtJ007355; Thu, 19 May 2005 12:11:58 +0300 (EEST) Message-ID: <428C585A.4080105@mif.vu.lt> Date: Thu, 19 May 2005 12:11:54 +0300 From: Rolandas Naujikas Organization: VU MIF User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050404) X-Accept-Language: en-us, en MIME-Version: 1.0 To: brooks@FreeBSD.org, ports@FreeBSD.org X-Enigmail-Version: 0.90.2.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-13 Content-Transfer-Encoding: 7bit X-eShield-AntiVirus: Passed X-eShield-AntiVirus-Message: Scanned by http://www.bluecoat.com/eShield X-eShield-AntiVirus: Passed X-eShield-AntiVirus-Message: Scanned by http://www.bluecoat.com/eShield Subject: sysutils/ganglia-monitor-core doesn't correctly detect high (>2GHz) cpu speed X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 May 2005 09:12:02 -0000 The original code in ganglia also has problems, because it use signed int for cpu_speed variable to determinate cpu freq value. In your patch it use signed long value. When cpu freq is over some value (mine has 3GHz), then overflow exists. The variables should be unsigned, to correctly determine cpu freq. (In kernel really it is unsinged int for 4.x) Rolandas