From owner-freebsd-ports  Sun Sep  3  7:45:20 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from ms.tokyo.jcom.ne.jp (ms.tokyo.jcom.ne.jp [210.234.123.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id B5AFA37B423; Sun,  3 Sep 2000 07:45:16 -0700 (PDT)
Received: from daemon.local.idaemons.org (203-165-77-17.sugnm1.kt.home.ne.jp [203.165.77.17])
	by ms.tokyo.jcom.ne.jp (8.9.3/3.7W 04/27/00) with ESMTP id XAA16336;
	Sun, 3 Sep 2000 23:45:15 +0900 (JST)
Received: by daemon.local.idaemons.org (8.9.3/3.7W) id XAA77734; Sun, 3 Sep 2000 23:44:43 +0900 (JST)
Date: Sun, 03 Sep 2000 23:44:42 +0900
Message-ID: <867l8tilgl.wl@archon.local.idaemons.org>
From: "Akinori -Aki- MUSHA" <knu@idaemons.org>
To: kiri@pis.toba-cmt.ac.jp
Cc: freebsd-ports@FreeBSD.org, asami@FreeBSD.org, shige@FreeBSD.org
Subject: Re: bsd.ruby.mk, bsd.gnome.mk, ... etc.
In-Reply-To: In your message of "Sun, 03 Sep 2000 20:44:58 +0900"
	<200009031145.e83BiwG85980@pis.toba-cmt.ac.jp>
References: <86g0nl8yr3.wl@archon.local.idaemons.org>
	<86d7ilj1eg.wl@archon.local.idaemons.org>
	<vqchf7xx2ci.fsf@silvia.hip.berkeley.edu>
	<200009031145.e83BiwG85980@pis.toba-cmt.ac.jp>
User-Agent: Wanderlust/2.3.0 (Roam) EMIKO/1.13.12 (Euglena sociabilis) FLIM/1.13.2 (Kasanui) APEL/10.2 MULE XEmacs/21.1 (patch 12) (Channel Islands) (i386--freebsd)
Organization: Associated I. Daemons
X-PGP-Public-Key: finger knu@FreeBSD.org
X-PGP-Fingerprint: 081D 099C 1705 861D 4B70  B04A 920B EFC7 9FD9 E1EE
X-PGP-Comment: I changed my key on 2000-08-10
MIME-Version: 1.0 (generated by EMIKO 1.13.12 - "Euglena sociabilis")
Content-Type: text/plain; charset=US-ASCII
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

At Sun, 03 Sep 2000 20:44:58 +0900,
kiri@pis.toba-cmt.ac.jp wrote:
> +INCLUDEMK_CATEGORIES=	elisp ruby gnome kde
> +__incmkfiles!=	\
> +	for cat in ${INCLUDEMK_CATEGORIES}; do \
> +		if echo ${CATEGORIES} | grep -wq $$cat; then \
> +			echo "bsd.$$cat.mk"; \
> +		fi; \
> +	done
> +.for file in ${__incmkfiles}
> +.include "${PORTSDIR}/Mk/${file}"
> +.endfor
>  check-categories:
>  .for cat in ${CATEGORIES}
>  	@if ${ECHO} ${VALID_CATEGORIES} | ${GREP} -wq ${cat}; then \

The idea seems fine, however, it'd better check if each file exists
instead of predefining INCLUDEMK_CATEGORIES:


__incmkfiles!=	\
	for cat in ${CATEGORIES}; do \
		mk="${PORTSDIR}/Mk/bsd.$$cat.mk"; \
		[ -f $$mk ] && echo $$mk; \
	done; exit 0
.if !empty(__incmkfiles)
.for file in ${__incmkfiles}
.include "${file}"
.endfor
.endif


Incidentally, bsd.emacs.mk should probably be renamed bsd.elisp.mk to
accomplish this. (I'm CC'ing this mail to the MAINTAINER of it)

And now I think bsd.cat.*.mk or such might look better...  Just
imagine this in the future:

$ ls -1 /usr/ports/Mk
bsd.elisp.mk
bsd.gnome.mk
bsd.kde.mk
bsd.perl5.mk
bsd.port.mk
bsd.port.post.mk
bsd.port.pre.mk
bsd.port.subdir.mk
bsd.python.mk
bsd.ruby.mk
bsd.sites.mk
bsd.windowmaker.mk


Comments on any of the above, everyone?

-- 
                           /
                          /__  __       
                         / )  )  ) )  /
Akinori -Aki- MUSHA aka / (_ /  ( (__(  @ idaemons.org / FreeBSD.org

"We're only at home when we're on the run, on the wing, on the fly"


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message