From owner-svn-ports-all@freebsd.org  Fri Feb  5 17:08:01 2021
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 6580E54CDEF;
 Fri,  5 Feb 2021 17:08:01 +0000 (UTC)
 (envelope-from mfechner@freebsd.org)
Received: from smtp.freebsd.org (smtp.freebsd.org
 [IPv6:2610:1c1:1:606c::24b:4])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DXMLT2PtFz3mgx;
 Fri,  5 Feb 2021 17:08:01 +0000 (UTC)
 (envelope-from mfechner@freebsd.org)
Received: from [IPv6:2a02:6d40:36ae:5f01:2d37:ef54:9298:1690] (unknown
 [IPv6:2a02:6d40:36ae:5f01:2d37:ef54:9298:1690])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client did not present a certificate)
 (Authenticated sender: mfechner)
 by smtp.freebsd.org (Postfix) with ESMTPSA id BC85F24D4E;
 Fri,  5 Feb 2021 17:08:00 +0000 (UTC)
 (envelope-from mfechner@freebsd.org)
Subject: Re: svn commit: r563296 - head/devel/grpc
To: Po-Chuan Hsieh <sunpoet@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
References: <202101301218.10UCIuNG081885@repo.freebsd.org>
 <2ee9c1a8-77cb-9db2-68c2-60d673240272@fechner.net>
 <46e3d6a4-79b1-e1b3-b27a-98de81944cda@freebsd.org>
 <CAMHz58S1ydqcNE6_Micu=HMxt1JYxnUup4kAi+okwPEWjcCvYA@mail.gmail.com>
 <3212e045-9e70-4741-3420-fe304a2cb228@freebsd.org>
 <CAMHz58TB+Yd-xpdQg8B+O_93zPSUsER9Wp4Vp4obbt_4LqFGyw@mail.gmail.com>
From: Matthias Fechner <mfechner@freebsd.org>
Message-ID: <20b56b6d-c31c-64ef-4685-136ba8961927@freebsd.org>
Date: Fri, 5 Feb 2021 18:07:57 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <CAMHz58TB+Yd-xpdQg8B+O_93zPSUsER9Wp4Vp4obbt_4LqFGyw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 05 Feb 2021 17:08:01 -0000

Am 05.02.2021 um 12:54 schrieb Po-Chuan Hsieh:
> I've submitted a patch at https://reviews.freebsd.org/D28491 
> <https://reviews.freebsd.org/D28491>.

I added my comments in the review.
An asset compiliation in gitlab is necessary, but this is not a problem 
as I will anyway commit a security update of gitlab which enforces this.

But I doubt the the grpc lib will work without problems. Maybe I'm wrong 
but why do gitlab trigger an assertion in a lib and another software 
should not do this.

Please commit the revision ASAP, thanks.

Gruß
Matthias

-- 

"Programming today is a race between software engineers striving to
build bigger and better idiot-proof programs, and the universe trying to
produce bigger and better idiots. So far, the universe is winning." --
Rich Cook