From owner-svn-src-head@freebsd.org Sun May 26 14:05:24 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8D8AC15A7349; Sun, 26 May 2019 14:05:24 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x533.google.com (mail-pg1-x533.google.com [IPv6:2607:f8b0:4864:20::533]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F16CC88710; Sun, 26 May 2019 14:05:23 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x533.google.com with SMTP id z3so2979819pgp.8; Sun, 26 May 2019 07:05:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OzrS8PAszKtZa5LRtmEd5+F6MeHDkOLe2jjqa6eMGBw=; b=XtUGuUfPAk5hsDl6nK4vPQJKejk2OdBbfsSOwTcaRDXH+Y5NGvpxtv1S719p7NT6tY gy0xifZbgZMOSRxX31mUrrnKi6B8nGl4CQAFMWGGPbYIJRK4BeWMt82029Po9vAxPz1k XPol4u/0ZrhadNZx5ZwkIE6Lpuj4sAlHrK5Np5d2M1sA4yU6+nyPS7/qZOC6lKOupy5i OWdtNRrm1sG03fvytzi/pqbIJg+lCxDS6zF/061+L9IiUnLlQhtfyJxIBFCG0W0gkvyA HdqDEWAlJ+pXOx+8CpEWZtDKzXVz9Iyi2hTTLhXKm/WvpN8uflnFz+KlHara7E4r6vY6 TQjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=OzrS8PAszKtZa5LRtmEd5+F6MeHDkOLe2jjqa6eMGBw=; b=XHlK1SqUvlex9FGvGVWI/wm8u833zauXqSE5vZsom1NNiIL/la90y+R5d8xmDSC5zi 5Sk3dK775uygHF8zl+UUQSQaK4rrGZA6dIIlbwGgVWr+J4kFcSEQEBHKSgNYYTprImm+ Ac0EJeGhdzKx+33BWE9TLVgLNq8CgDQWnCgRl737gaaQINxNIXyUqaOKIZIL28lUXU3+ ViqsjW72X/IQHBuo59bI2TfldTgYy3UvkyafupHXiLGKZ3Ik69UGWvZlzaIsw+mZ/kcu 17YITzK+3pjvLZx9GeBlAAF3+UwNf+y5i19QsrLLdFML20I+LfNfe+XXJUi9lQvG9NLk WpGA== X-Gm-Message-State: APjAAAWzIba7mVfRpzNOzKK/KKqwFWwkByRg/9MLbSc5BSDCKX01b3KE kwbiNXzfLVcPb2Eho0wsesvhw9X4Bao= X-Google-Smtp-Source: APXvYqwsMAWCbvj9N7r7VJEbPStYdxle9vVZK70HF20qOv0uDjikNqZySllzaCvXb/aSP/5lNXPLWg== X-Received: by 2002:a17:90a:d683:: with SMTP id x3mr24761773pju.42.1558879521915; Sun, 26 May 2019 07:05:21 -0700 (PDT) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id i7sm8405741pfo.19.2019.05.26.07.05.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 26 May 2019 07:05:21 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r348286 - in head/sys/dev: ctau cxgbe From: Enji Cooper X-Mailer: iPhone Mail (16F156) In-Reply-To: <201905261241.x4QCf3ng086605@repo.freebsd.org> Date: Sun, 26 May 2019 07:05:20 -0700 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org, gallatin@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <2BE2FA91-38D0-4730-8A6A-BAF5037EB24E@gmail.com> References: <201905261241.x4QCf3ng086605@repo.freebsd.org> To: Alexey Dokuchaev X-Rspamd-Queue-Id: F16CC88710 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.977,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 May 2019 14:05:24 -0000 > On May 26, 2019, at 05:41, Alexey Dokuchaev wrote: >=20 > Author: danfe (ports committer) > Date: Sun May 26 12:41:03 2019 > New Revision: 348286 > URL: https://svnweb.freebsd.org/changeset/base/348286 >=20 > Log: > Fix two errors reported by PVS Studio: V646 Consider inspecting the > application's logic. It's possible that 'else' keyword is missing. >=20 > Reviewed by: gallatin, np, pfg > Approved by: pfg > Differential Revision: https://reviews.freebsd.org/D20396 >=20 > Modified: > head/sys/dev/ctau/ctddk.c > head/sys/dev/cxgbe/t4_main.c >=20 > Modified: head/sys/dev/ctau/ctddk.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > --- head/sys/dev/ctau/ctddk.c Sun May 26 03:52:35 2019 (r348285) > +++ head/sys/dev/ctau/ctddk.c Sun May 26 12:41:03 2019 (r348286) > @@ -237,7 +237,7 @@ int ct_set_clk (ct_chan_t *c, int clk) > if (c->mode =3D=3D M_E1) { > ct_setup_e1 (c->board); > return 0; > - } if (c->mode =3D=3D M_G703) { > + } else if (c->mode =3D=3D M_G703) { > ct_setup_g703 (c->board); > return 0; > } else This seems like a good candidate for a switch-case logical block. Cheers, -Enji=