From owner-svn-src-all@freebsd.org Sat Sep 5 21:27:01 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id C058B3D6A42; Sat, 5 Sep 2020 21:27:01 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4BkSKx079Dz3fCR; Sat, 5 Sep 2020 21:27:00 +0000 (UTC) (envelope-from carpeddiem@gmail.com) Received: by mail-il1-f175.google.com with SMTP id w8so9363618ilj.8; Sat, 05 Sep 2020 14:27:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kUWMTdqUBBtouw+qawIqnyQsOj0vZEUskXNBh/MBe68=; b=o/urz8MkZevp3bO7NSdmAch6yZob46mRB2z7sVxxaLJbzx/9JGHdSmtYJcq1XBMIga YXcBlzApkwDaLUfk+jsbs3mZLwhyyUo54XhJHkzw22+P10IeU57NMroFzbmylcn/38pQ P32hMimg7219G/d9xS1Dbrwr6WtTHh5Acw5g9MXUz1qL+vK66fqk3BEX1VAa6CEe66Ou MrFu3dIi4BSPwi2dq5ExoBCoRcsyiDoprgIaJ+G3P65zyT4GUDoaIdb1lckqhsSScl/p CdvOGMjeONvNEAIYQfGvkxEPEtWuXYwsTFerA7FisBN5dFTE/lEjKVyMh15MWER9gfhH 6usA== X-Gm-Message-State: AOAM531hORm2dZbzU5YvstdDiQLehophP/XikWwCpH6ei2kV3x3ZFPDO 5UeUUn+qKpfV1hSYWBCSzVw+2MmyTLDTWkpAiww4hvOzNh8= X-Google-Smtp-Source: ABdhPJx5w5RuF400u7cF7z/X5nbDsebPHMTcBIgmWlNg4sKfKjiShdccg5UYUtUs2cTCxUXgxc4nThLhvl1j+GW0G/o= X-Received: by 2002:a92:9a0b:: with SMTP id t11mr12671024ili.98.1599341219352; Sat, 05 Sep 2020 14:26:59 -0700 (PDT) MIME-Version: 1.0 References: <202009012119.081LJERb018106@repo.freebsd.org> <95844C00-D10A-456D-AD29-DF572043074F@fh-muenster.de> <20200902020507.GA38274@FreeBSD.org> <20200902180626.GA88595@FreeBSD.org> <6124a908-25a5-e023-16da-7963ba229b7f@FreeBSD.org> <08636D5E-AA07-4AE7-B5AC-656B08CF564B@fh-muenster.de> <20200903024226.GA54078@FreeBSD.org> <60ea593f-8258-e30d-b897-f162168b44d3@cs.duke.edu> <20200905010510.GA26297@lonesome.com> In-Reply-To: From: Ed Maste Date: Sat, 5 Sep 2020 17:26:47 -0400 Message-ID: Subject: Re: svn commit: r365071 - in head/sys: net net/altq net/route net80211 netgraph netgraph/atm netgraph/atm/ccatm netgraph/atm/sscfu netgraph/atm/sscop netgraph/atm/uni netgraph/bluetooth/common netgraph... To: Warner Losh Cc: Kevin Bowling , src-committers , svn-src-all , svn-src-head Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4BkSKx079Dz3fCR X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of carpeddiem@gmail.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=carpeddiem@gmail.com X-Spamd-Result: default: False [-2.94 / 15.00]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; FREEFALL_USER(0.00)[carpeddiem]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17:c]; RCVD_TLS_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; DMARC_NA(0.00)[freebsd.org]; NEURAL_HAM_LONG(-0.93)[-0.926]; RCPT_COUNT_FIVE(0.00)[5]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.991]; RCVD_IN_DNSWL_NONE(0.00)[209.85.166.175:from]; NEURAL_HAM_MEDIUM(-1.02)[-1.023]; FORGED_SENDER(0.30)[emaste@freebsd.org,carpeddiem@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.166.175:from]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; FROM_NEQ_ENVFROM(0.00)[emaste@freebsd.org,carpeddiem@gmail.com]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Sep 2020 21:27:01 -0000 On Sat, 5 Sep 2020 at 16:41, Warner Losh wrote: > >> Fixed: >> - *_FOREACH now has a space before (, equivalent to for (;;) > > Except pretty much everywhere we don't have a space there... Why not? Why should TAILQ_FOREACH have a different style from a for loop? > broke all alignment of variables and comments that were done. > broke purposely outdented code in statistics function > broke all err() calls to wrap too much I had all of these under "indifferent" already, or are more examples of already covered cases (e.g. what seems to be string argument wrapping). > extra headers still included. This is probably not the job of a formatter though. >> - function argument wrapping (see write_glyph_buf) >> - leading indentation and args-per-line (print_font_info) > > An interesting experiment, but there's far more worse after than before. The rearranging of carefully aligned elements is an especially galling change for some people (myself included). I disagree this is far worse. If we fixed the wrapping on the second line of if/for conditions I'd say the benefit of letting tooling take care of the formatting outweighs the perhaps slightly less appealing formatting.