From owner-freebsd-net@freebsd.org Mon Jan 9 13:15:00 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0DBC7CA629B; Mon, 9 Jan 2017 13:15:00 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from butcher-nb.yandex.net (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) by mx1.freebsd.org (Postfix) with ESMTP id D1CB914CC; Mon, 9 Jan 2017 13:14:58 +0000 (UTC) (envelope-from ae@FreeBSD.org) Subject: Re: [RFC/RFT] projects/ipsec To: "Bjoern A. Zeeb" References: <2bd32791-944f-2417-41e9-e0fe1c705502@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, freebsd-net@FreeBSD.org, George Neville-Neil From: "Andrey V. Elsukov" Message-ID: <7d2366eb-caca-e9b1-174c-3b7cde96e45f@FreeBSD.org> Date: Mon, 9 Jan 2017 16:14:16 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jan 2017 13:15:00 -0000 On 09.01.2017 14:38, Bjoern A. Zeeb wrote: > On 27 Dec 2016, at 10:18, Andrey V. Elsukov wrote: > >> So, if there will no objection, I'll merge projects/ipsec into head/ >> within two weeks. > > I still keep seeing almost daily changes to the branch and am having a > hard time to convince myself to do a proper review that way. I would > very much prefer this to be (a) either become stable first and then give > people a chance, or (b) see if you can break out small self-contained > changes put them up into review and merge them piece by piece making it > a lot easier to convince ourselves that things still look good. Hi, yes, I hope I have fixed all found issues, now I will test the changes in our environment. I prefer the first way (a), because another splitting into small pieces requires a lot of time that I don't have. So, if you want to do a review, you are welcome :) Now I'll be focused on testing with different IKEd, documenting the changes, and fixing possible NO_INET/NO_INET6 related build issues. -- WBR, Andrey V. Elsukov