From owner-freebsd-ports@FreeBSD.ORG Tue Nov 4 19:09:18 2003 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3E8E816A4CE; Tue, 4 Nov 2003 19:09:18 -0800 (PST) Received: from sccrmhc11.comcast.net (sccrmhc11.comcast.net [204.127.202.55]) by mx1.FreeBSD.org (Postfix) with ESMTP id 212ED43F3F; Tue, 4 Nov 2003 19:09:17 -0800 (PST) (envelope-from philip@p6m7g8.com) Received: from p6m7g8.com (pcp04982508pcs.hyatsv01.md.comcast.net[68.48.52.169]) by comcast.net (sccrmhc11) with SMTP id <2003110503091601100refnfe>; Wed, 5 Nov 2003 03:09:16 +0000 Message-ID: <3FA86AB2.80008@p6m7g8.com> Date: Tue, 04 Nov 2003 22:12:50 -0500 From: "Philip M. Gollucci" User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.5a) Gecko/20030616 Thunderbird/0.1a X-Accept-Language: en-us, en MIME-Version: 1.0 To: foxfair@FreeBSD.org References: <20031104092809.GG70411@drago.fomokka.net> In-Reply-To: <20031104092809.GG70411@drago.fomokka.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: ports@freebsd.org Subject: Re: [patch review] Upgrade ports biology/p5-AcePerl (fwd) X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Nov 2003 03:09:18 -0000 At first glance, this looks good, make make install make deinstall make package all seem to work as expected. All the t/* pass as well. Foxfair Hu wrote: >----- Forwarded message from Foxfair Hu ----- > > > >>Subject: [patch review] Upgrade ports biology/p5-AcePerl >>To: philip@p6m7g8.com >>Date: Mon, 3 Nov 2003 16:00:51 +0800 >> >>Hello, >> >> Please review this patch to upgrade freebsd ports biology/p5-AcePerl >>from 1.83 to 1.87. >> >>foxfair >> >> >> > > > >>diff -ruN /usr/ports/biology/p5-AcePerl/Makefile ./Makefile >>--- /usr/ports/biology/p5-AcePerl/Makefile Mon Oct 27 14:49:23 2003 >>+++ ./Makefile Fri Oct 31 15:11:36 2003 >>@@ -6,7 +6,7 @@ >> # >> >> PORTNAME= AcePerl >>-PORTVERSION= 1.83 >>+PORTVERSION= 1.87 >> CATEGORIES= biology databases perl5 >> MASTER_SITES= ${MASTER_SITE_PERL_CPAN} >> MASTER_SITE_SUBDIR= Ace >>@@ -20,6 +20,7 @@ >> >> PERL_CONFIGURE= yes >> >>+MAN1= ace.pl.1 >> MAN3= Ace.3 Ace::Browser::AceSubs.3 Ace::Browser::SearchSubs.3 \ >> Ace::Browser::SiteDefs.3 Ace::Graphics::Fk.3 \ >> Ace::Graphics::Glyph.3 Ace::Graphics::Glyph::anchored_arrow.3 \ >>@@ -42,6 +43,6 @@ >> >> post-patch: >> @ ${SED} -e 's|XX__CC__XX|${CC}|' < ${FILESDIR}/FREEBSD_DEF \ >>- > ${WRKSRC}/ace/wmake/FREEBSD_DEF >>+ > ${WRKSRC}/acelib/wmake/FREEBSD_DEF >> >> .include >>diff -ruN /usr/ports/biology/p5-AcePerl/distinfo ./distinfo >>--- /usr/ports/biology/p5-AcePerl/distinfo Wed Sep 10 20:57:29 2003 >>+++ ./distinfo Fri Oct 31 14:59:03 2003 >>@@ -1 +1 @@ >>-MD5 (AcePerl-1.83.tar.gz) = d1cc9e852ce7fb23a0f2eac739b040fb >>+MD5 (AcePerl-1.87.tar.gz) = e42bc9b26c34ff9604c30d103d445818 >>diff -ruN /usr/ports/biology/p5-AcePerl/files/patch-aa ./files/patch-aa >>--- /usr/ports/biology/p5-AcePerl/files/patch-aa Mon Aug 13 19:27:36 2001 >>+++ ./files/patch-aa Fri Oct 31 15:02:55 2003 >>@@ -1,5 +1,5 @@ >>---- ace/wh/mystdlib.h.orig Mon Jul 16 23:04:45 2001 >>-+++ ace/wh/mystdlib.h Mon Aug 13 12:42:25 2001 >>+--- acelib/wh/mystdlib.h.orig Mon Jul 16 23:04:45 2001 >>++++ acelib/wh/mystdlib.h Mon Aug 13 12:42:25 2001 >> @@ -161,7 +161,8 @@ >> #endif >> >>@@ -10,8 +10,8 @@ >> >> #ifdef WIN32 >> #include >>---- ace/wh/mydirent.h.orig Mon Jul 16 23:04:45 2001 >>-+++ ace/wh/mydirent.h Mon Aug 13 12:41:59 2001 >>+--- acelib/wh/mydirent.h.orig Mon Jul 16 23:04:45 2001 >>++++ acelib/wh/mydirent.h Mon Aug 13 12:41:59 2001 >> @@ -55,7 +55,7 @@ >> extern char *getwd(char *pathname) ; >> #endif /* HP || SOLARIS || WIN32 */ >>diff -ruN /usr/ports/biology/p5-AcePerl/files/patch-ab ./files/patch-ab >>--- /usr/ports/biology/p5-AcePerl/files/patch-ab Fri Jul 28 21:16:10 2000 >>+++ ./files/patch-ab Fri Oct 31 15:05:43 2003 >>@@ -1,9 +1,9 @@ >>---- ace/memsubs.c.orig Mon Jan 11 02:01:29 1999 >>-+++ ace/memsubs.c Thu Jul 27 17:18:45 2000 >>+--- acelib/memsubs.c.orig Mon Nov 25 03:27:20 2002 >>++++ acelib/memsubs.c Fri Oct 31 15:05:01 2003 >> @@ -21,7 +21,7 @@ >> #if defined(NEXT) || defined(HP) || defined(MACINTOSH) >> extern void* malloc(mysize_t size) ; >>- #elif !defined(WIN32) >>+ #elif !defined(WIN32) && !defined(DARWIN) >> -#include /* normal machines */ >> +#include /* normal machines */ >> #endif >>diff -ruN /usr/ports/biology/p5-AcePerl/pkg-plist ./pkg-plist >>--- /usr/ports/biology/p5-AcePerl/pkg-plist Mon Oct 27 14:49:23 2003 >>+++ ./pkg-plist Fri Oct 31 15:23:33 2003 >>@@ -1,3 +1,4 @@ >>+bin/ace.pl >> %%SITE_PERL%%/%%PERL_ARCH%%/Ace.pm >> %%SITE_PERL%%/%%PERL_ARCH%%/Ace/Browser/AceSubs.pm >> %%SITE_PERL%%/%%PERL_ARCH%%/Ace/Browser/GeneSubs.pm >>@@ -41,7 +42,6 @@ >> %%SITE_PERL%%/%%PERL_ARCH%%/Ace/Sequence/Transcript.pm >> %%SITE_PERL%%/%%PERL_ARCH%%/Ace/SocketServer.pm >> %%SITE_PERL%%/%%PERL_ARCH%%/GFF/Filehandle.pm >>-%%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/.packlist >> %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/Freesubs/Freesubs.bs >> %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/Freesubs/Freesubs.so >> %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/Object/_asAce.al >>@@ -106,6 +106,9 @@ >> %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/split.al >> %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/status.al >> %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/timestamps.al >>+%%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/title.al >>+%%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/version.al >>+%%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/.packlist >> @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/Sequence/Feature >> @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/Sequence >> @dirrm %%SITE_PERL%%/%%PERL_ARCH%%/auto/Ace/RPC >> >> > > > > >----- End forwarded message ----- > >