From owner-svn-src-all@FreeBSD.ORG Mon Sep 13 15:10:31 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B87151065679; Mon, 13 Sep 2010 15:10:31 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 88DCC8FC14; Mon, 13 Sep 2010 15:10:31 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 2393146C0D; Mon, 13 Sep 2010 11:10:31 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 3F47A8A03C; Mon, 13 Sep 2010 11:10:30 -0400 (EDT) From: John Baldwin To: Andriy Gapon Date: Mon, 13 Sep 2010 08:48:33 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009131147.o8DBla8x095589@svn.freebsd.org> <4C8E144C.3030405@freebsd.org> In-Reply-To: <4C8E144C.3030405@freebsd.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201009130848.34144.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 13 Sep 2010 11:10:30 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: "Jayachandran C." , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212550 - head/sys/mips/rmi X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Sep 2010 15:10:31 -0000 On Monday, September 13, 2010 8:08:44 am Andriy Gapon wrote: > on 13/09/2010 14:47 Jayachandran C. said the following: > > Author: jchandra > > Date: Mon Sep 13 11:47:35 2010 > > New Revision: 212550 > > URL: http://svn.freebsd.org/changeset/base/212550 > > > > Log: > > bus_add_child method is needed now. > > Just a note: bus_add_child method needs to be defined only if it's actually > used, i.e. a device/bus has at least one child that calls BUS_ADD_CHILD. And that generally only happens in device_identify() methods of drivers that live on the bus. If a bus can self-enumerate devices (e.g. PCI) it should use device_add_child() directly. -- John Baldwin