From owner-svn-src-head@FreeBSD.ORG  Tue Dec  3 13:26:37 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B4ED0C56;
 Tue,  3 Dec 2013 13:26:37 +0000 (UTC)
Received: from svn.freebsd.org (svn.freebsd.org
 [IPv6:2001:1900:2254:2068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A11FD124F;
 Tue,  3 Dec 2013 13:26:37 +0000 (UTC)
Received: from svn.freebsd.org ([127.0.1.70])
 by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id rB3DQb0o030758;
 Tue, 3 Dec 2013 13:26:37 GMT (envelope-from pjd@svn.freebsd.org)
Received: (from pjd@localhost)
 by svn.freebsd.org (8.14.7/8.14.7/Submit) id rB3DQb0I030757;
 Tue, 3 Dec 2013 13:26:37 GMT (envelope-from pjd@svn.freebsd.org)
Message-Id: <201312031326.rB3DQb0I030757@svn.freebsd.org>
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Date: Tue, 3 Dec 2013 13:26:37 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r258866 - head/lib/libcasper
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Dec 2013 13:26:37 -0000

Author: pjd
Date: Tue Dec  3 13:26:37 2013
New Revision: 258866
URL: http://svnweb.freebsd.org/changeset/base/258866

Log:
  Fix comparisons in assertions.
  
  Reported by:	Coverity
  Coverity CID:	1130048

Modified:
  head/lib/libcasper/libcasper.c

Modified: head/lib/libcasper/libcasper.c
==============================================================================
--- head/lib/libcasper/libcasper.c	Tue Dec  3 04:32:02 2013	(r258865)
+++ head/lib/libcasper/libcasper.c	Tue Dec  3 13:26:37 2013	(r258866)
@@ -114,7 +114,7 @@ service_free(struct service *service)
 {
 	struct service_connection *sconn;
 
-	PJDLOG_ASSERT(service->s_magic = SERVICE_MAGIC);
+	PJDLOG_ASSERT(service->s_magic == SERVICE_MAGIC);
 
 	service->s_magic = 0;
 	while ((sconn = service_connection_first(service)) != NULL)
@@ -130,7 +130,7 @@ service_connection_add(struct service *s
 	struct service_connection *sconn;
 	int serrno;
 
-	PJDLOG_ASSERT(service->s_magic = SERVICE_MAGIC);
+	PJDLOG_ASSERT(service->s_magic == SERVICE_MAGIC);
 
 	sconn = malloc(sizeof(*sconn));
 	if (sconn == NULL) {
@@ -168,7 +168,7 @@ service_connection_remove(struct service
     struct service_connection *sconn)
 {
 
-	PJDLOG_ASSERT(service->s_magic = SERVICE_MAGIC);
+	PJDLOG_ASSERT(service->s_magic == SERVICE_MAGIC);
 	PJDLOG_ASSERT(sconn->sc_magic == SERVICE_CONNECTION_MAGIC);
 
 	TAILQ_REMOVE(&service->s_connections, sconn, sc_next);
@@ -206,7 +206,7 @@ service_connection_first(struct service 
 {
 	struct service_connection *sconn;
 
-	PJDLOG_ASSERT(service->s_magic = SERVICE_MAGIC);
+	PJDLOG_ASSERT(service->s_magic == SERVICE_MAGIC);
 
 	sconn = TAILQ_FIRST(&service->s_connections);
 	PJDLOG_ASSERT(sconn == NULL ||