From owner-freebsd-fs@FreeBSD.ORG  Tue Aug  8 21:02:42 2006
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
X-Original-To: freebsd-fs@FreeBSD.org
Delivered-To: freebsd-fs@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 98C5A16A4DA
	for <freebsd-fs@FreeBSD.org>; Tue,  8 Aug 2006 21:02:42 +0000 (UTC)
	(envelope-from markus@trippelsdorf.de)
Received: from blue-ld-038.synserver.de (smtp-out-42.synserver.de
	[217.119.50.42]) by mx1.FreeBSD.org (Postfix) with SMTP id C924143D8F
	for <freebsd-fs@FreeBSD.org>; Tue,  8 Aug 2006 21:02:20 +0000 (GMT)
	(envelope-from markus@trippelsdorf.de)
Received: (qmail 25454 invoked by uid 0); 8 Aug 2006 21:02:15 -0000
X-SynServer-RemoteDnsName: port-212-202-34-169.dynamic.qsc.de
X-SynServer-AuthUser: markus@trippelsdorf.de
Received: from port-212-202-34-169.dynamic.qsc.de (HELO bsd.trippelsdorf.de)
	(212.202.34.169)
	by mx-06.synserver.de with SMTP; 8 Aug 2006 21:02:15 -0000
Date: Tue, 8 Aug 2006 23:02:11 +0200
From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
Message-ID: <20060808210211.GA730@bsd.trippelsdorf.de>
References: <20060808195202.GA1564@garage.freebsd.pl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060808195202.GA1564@garage.freebsd.pl>
Cc: freebsd-fs@FreeBSD.org, freebsd-current@FreeBSD.org,
	freebsd-geom@FreeBSD.org
Subject: Re: GJournal (hopefully) final patches.
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 08 Aug 2006 21:02:42 -0000

On Tue, Aug 08, 2006 at 09:52:02PM +0200, Pawel Jakub Dawidek wrote:
> 
> I'm pleased to announce hopefully the final gjournal patches.
...
> 
> Patches for 6-STABLE:
> 
> 	http://people.freebsd.org/~pjd/patches/gjournal6_20060808.patch
> 
> To apply the patches:
> 
> 	# cd /usr/src
> 	# mkdir sys/geom/journal sbin/geom/class/journal sys/modules/geom/geom_journal
> 	# patch < gjournal_20060808.patch
> 
> Now you need to recompile the world and the kernel. Remember to add
> 'options UFS_GJOURNAL' to your kernel configuration file.

It does not compile with -Werror on my AMD64 system running STABLE:

cc -O2 -pipe -march=k8 -DRESCUE -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /usr/src/bin/test/test.c
/usr/src/sbin/fsck_ffs/gjournal.c: In function `gjournal_check':
/usr/src/sbin/fsck_ffs/gjournal.c:717: warning: dereferencing type-punned pointer will break strict-aliasing rules
*** Error code 1

-- 
Markus