From owner-p4-projects@FreeBSD.ORG  Sun Jan 18 18:11:09 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9C7A21065674; Sun, 18 Jan 2009 18:11:09 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 5CB46106564A
	for <perforce@freebsd.org>; Sun, 18 Jan 2009 18:11:09 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 4A22D8FC22
	for <perforce@freebsd.org>; Sun, 18 Jan 2009 18:11:09 +0000 (UTC)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n0IIB8IP006248
	for <perforce@freebsd.org>; Sun, 18 Jan 2009 18:11:08 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n0IIB83L006246
	for perforce@freebsd.org; Sun, 18 Jan 2009 18:11:08 GMT
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Date: Sun, 18 Jan 2009 18:11:08 GMT
Message-Id: <200901181811.n0IIB83L006246@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 156341 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 18 Jan 2009 18:11:10 -0000

http://perforce.freebsd.org/chv.cgi?CH=156341

Change 156341 by rwatson@rwatson_freebsd_capabilities on 2009/01/18 18:10:56

	Regression test to make sure that pdfork(2)-generated processes
	aren't visible using waitpid(2).

Affected files ...

.. //depot/projects/trustedbsd/capabilities/src/tools/regression/procdesc/procdesc_test.c#4 edit

Differences ...

==== //depot/projects/trustedbsd/capabilities/src/tools/regression/procdesc/procdesc_test.c#4 (text+ko) ====

@@ -30,14 +30,16 @@
  * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  *
- * $P4: //depot/projects/trustedbsd/capabilities/src/tools/regression/procdesc/procdesc_test.c#3 $
+ * $P4: //depot/projects/trustedbsd/capabilities/src/tools/regression/procdesc/procdesc_test.c#4 $
  */
 
 #include <sys/types.h>
 #include <sys/procdesc.h>
 #include <sys/stat.h>
+#include <sys/wait.h>
 
 #include <err.h>
+#include <errno.h>
 #include <fcntl.h>
 #include <signal.h>
 #include <stdio.h>
@@ -171,5 +173,22 @@
 		close(fd);
 	}
 
+	printf("4. Confirm pdfork() process isn't visible to waitpid()\n");
+
+	realpid = pdfork(&fd);
+	if (realpid < 0)
+		err(-1, "pdfork");
+	if (realpid == 0) {
+		if (execve(sleep_argv[0], sleep_argv, environ) < 0)
+			err(-1, "%s", sleep_argv[0]);
+	} else {
+		sleep(10);
+		pid = waitpid(realpid, NULL, 0);
+		if (pid >= 0)
+			errx(-1, "waitpid unexpectedly returned %d", pid);
+		if (errno != ECHILD)
+			err(-1, "waitpid unexpected error %d", errno);
+	}
+
 	exit(0);
 }