From owner-freebsd-ports@FreeBSD.ORG Wed Feb 27 17:57:13 2008 Return-Path: Delivered-To: ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 829FD106566B for ; Wed, 27 Feb 2008 17:57:13 +0000 (UTC) (envelope-from rtomayko@gmail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.169]) by mx1.freebsd.org (Postfix) with ESMTP id 11E8A8FC13 for ; Wed, 27 Feb 2008 17:57:12 +0000 (UTC) (envelope-from rtomayko@gmail.com) Received: by ug-out-1314.google.com with SMTP id y2so474229uge.37 for ; Wed, 27 Feb 2008 09:57:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; bh=mmgS/Z13JVz41bybhLijUUvYSAF+r9UFQSQqTXdNu+c=; b=cqFTawfABNyW/c342+rXt4qPCOwmduNZAHaiPdwzfl5O0lIDCKR6cDJK76UWq5PvjB57FhlBGVerrk5i24yXA4uVVbfA/fMgc+BT+YsshbtwCrRnDK0THxIWu7mPM3Z9vAlWhD5bNnZ+0O01ZaiMquXDVBKQtqcPqsDfjJ9MPKE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject:references:in-reply-to:content-type:content-transfer-encoding; b=Ygw7BbJArDjSnomVAXwkoTVmbu9POd6jFoxOnnfTwIAJz8c4Z1eKu9GdfBGgVp4aYd7E8yHE+shkBAEstjxZeNNUSzi0KkVRXICfYsCZfw9Hw9zIw9NQD9N0wflCuwWTPBSQxpt/KotNt27ySvf7RmP0oHTtUaqS7jU2nlUvkXA= Received: by 10.142.44.11 with SMTP id r11mr5569257wfr.13.1204135030180; Wed, 27 Feb 2008 09:57:10 -0800 (PST) Received: from siswai.local ( [76.189.72.104]) by mx.google.com with ESMTPS id 3sm1473959wrh.26.2008.02.27.09.57.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 27 Feb 2008 09:57:06 -0800 (PST) Message-ID: <47C5A46D.4030800@gmail.com> Date: Wed, 27 Feb 2008 12:57:01 -0500 From: Ryan Tomayko User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Vsevolod Stakhov References: <47C46645.80700@gmail.com> <47C54841.3060601@highsecure.ru> In-Reply-To: <47C54841.3060601@highsecure.ru> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: ports@freebsd.org, "Sergey A. Osokin" Subject: Re: nginx upstream_fair module patch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Feb 2008 17:57:13 -0000 Vsevolod Stakhov wrote: > I don't think that it is a good idea to have 3-rd party code as FreeBSD > ports patches (ports patches are FreeBSD specific code). I think it > would be better to have some directive for enabling extra modules for > nginx and make subports for such modules, in the similar way as php > ports for example. That makes sense. Sergey responded off list with the exact same advice. I'll take it. > Here is a small patch. Maybe this should be better done using OPTIONS. It looks like both php and mail/postfix would be good examples of how something like this might be best accomplished. Thanks for the example; I think I basically understand what's going on here. Thanks -- Ryan Tomayko http://tomayko.com http://lesscode.org