From owner-freebsd-pf@FreeBSD.ORG  Sun Dec 14 19:36:40 2014
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 1422AE1F
 for <freebsd-pf@freebsd.org>; Sun, 14 Dec 2014 19:36:40 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id E28AA669
 for <freebsd-pf@freebsd.org>; Sun, 14 Dec 2014 19:36:39 +0000 (UTC)
Received: from phabric-backend.isc.freebsd.org
 (phabric-backend.isc.freebsd.org [127.0.1.5])
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id
 sBEJadII091446
 for <freebsd-pf@freebsd.org>; Sun, 14 Dec 2014 19:36:39 GMT
 (envelope-from root@phabric-backend.isc.freebsd.org)
Received: (from root@localhost)
 by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id sBEJadtX091445;
 Sun, 14 Dec 2014 19:36:39 GMT (envelope-from root)
Date: Sun, 14 Dec 2014 19:36:39 +0000
To: freebsd-pf@freebsd.org
From: "zec (Marko Zec)" <phabric-noreply@FreeBSD.org>
Subject: [Differential] [Commented On] D1309: VIMAGE PF fixes #1
Message-ID: <d4981c01a9123e318d81edb2cd54f2d8@localhost.localdomain>
X-Priority: 3
Thread-Topic: D1309: VIMAGE PF fixes #1
X-Herald-Rules: none
X-Phabricator-To: <PHID-USER-2q5asccazp7ohcpzdm6o>
X-Phabricator-To: <PHID-USER-ug3kdqciycpghwfscl6v>
X-Phabricator-To: <PHID-USER-ogl2udicsobdviqdulu3>
X-Phabricator-To: <PHID-USER-mqlw6f5jjiqhbs4co7yd>
X-Phabricator-To: <PHID-USER-d7hlhjvonwbh6sezyfcn>
X-Phabricator-To: <PHID-USER-jfdfp3ujmysz623mloir>
X-Phabricator-To: <PHID-USER-q3rwaaecfkbtb4lxr2gr>
X-Phabricator-To: <PHID-USER-gwqhkhyjx2ztt7b5iohf>
X-Phabricator-To: <PHID-USER-k5bbpaejfd56ik2tjj37>
X-Phabricator-To: <PHID-USER-wmu3dipuua4kxljjqlii>
X-Phabricator-To: <PHID-USER-sfbxp2cksgub2ywlvupr>
X-Phabricator-To: <PHID-USER-hh4avozwa3ssphnwhjxx>
X-Phabricator-To: <PHID-USER-xs5piezwnsa6epounp3t>
X-Phabricator-To: <PHID-USER-d4twv4w2hsoq7prc6boa>
X-Phabricator-To: <PHID-USER-wsgmn2xibp2yi52xz6fn>
X-Phabricator-Cc: <PHID-MLST-crbi54kg7ihel5ezzzmu>
X-Phabricator-Cc: <PHID-MLST-5lcr2rqsbmuavxbsw4mm>
X-Phabricator-Cc: <PHID-MLST-c3bj6mfydtlqmuethodc>
In-Reply-To: <differential-rev-PHID-DREV-s3ozye4th7n7swlll3te-req@FreeBSD.org>
References: <differential-rev-PHID-DREV-s3ozye4th7n7swlll3te-req@FreeBSD.org>
Thread-Index: NzA2ZjJlODRkOGZmNmYwM2M1MmQ1N2YzYTJkIFSN5sc=
X-Phabricator-Sent-This-Message: Yes
X-Mail-Transport-Agent: MetaMTA
X-Auto-Response-Suppress: All
X-Phabricator-Mail-Tags: <differential-comment>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="utf-8"
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
 \(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf/>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Dec 2014 19:36:40 -0000

zec added inline comments.

INLINE COMMENTS
  sys/netpfil/pf/pf_ioctl.c:3804 Perhaps SI_ORDER_MIDDLE could work here instead of (SI_ORDER_ANY - 255)?

REVISION DETAIL
  https://reviews.freebsd.org/D1309

To: rodrigc, bz, glebius, np, melifaro, hrs, wollman, bryanv, rpaulo, adrian, gnn, hiren, rwatson, trociny, zec
Cc: freebsd-virtualization, freebsd-pf, freebsd-net