Date: Tue, 5 Feb 2002 09:20:01 -0800 (PST) From: Peter Pentchev <roam@ringlet.net> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/34639: IPFW skipto works too slow Message-ID: <200202051720.g15HK1b50930@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/34639; it has been noted by GNATS. From: Peter Pentchev <roam@ringlet.net> To: Vladimir Ivanov <wawa@yandex-team.ru> Cc: bug-followup@FreeBSD.org Subject: Re: kern/34639: IPFW skipto works too slow Date: Tue, 5 Feb 2002 19:10:45 +0200 On Tue, Feb 05, 2002 at 08:03:17PM +0300, Vladimir Ivanov wrote: > Peter Pentchev wrote: > > > On Tue, Feb 05, 2002 at 05:53:19PM +0300, wawa@yandex-team.ru wrote: > > > >>>Number: 34639 > >>>Category: kern > >>>Synopsis: IPFW skipto works too slow > >>>Description: > >>> > >>The original implementation of skipto rule use brute-force to find the appropriate rule. > >>The suggested implementation use indexed access. > >> > > > > Your suggested implementation has just one drawback: it assumes that > > the rule exists. AFAIR, the current skipto implementation will skip > > to the lowest-numbered rule no lower than the specified one, so you > > can safely delete the rule with that specific number and still rest > > assured that the following rules will be honored. > > > Yes you're right. But my idea was to make it more intuitive. The > domcumented behaviour can be achived by a couple lines of code which > can be placed in the ad_ and del_ procedure but not in chk_ . We can > just fill the index with duplicated values. Doesn't it ? It's important > because it saves running time significantly still. I said 'just one drawback'; this implies that I like your change :) Right now I do not have the opportunity to look at the ipfw code and come up with patches, but yes, a couple of lines in adding and deleting rules should be enough. Keep up the good work, and hopefully somebody who knows their way around ipfw will notice this and commit it after suitable refinement :) G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@FreeBSD.org PGP key: http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint FDBA FD79 C26F 3C51 C95E DF9E ED18 B68D 1619 4553 This sentence every third, but it still comprehensible. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200202051720.g15HK1b50930>