From owner-cvs-all@FreeBSD.ORG Mon Jun 9 16:15:25 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 098861065672 for ; Mon, 9 Jun 2008 16:15:25 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6]) by mx1.freebsd.org (Postfix) with ESMTP id B08348FC12 for ; Mon, 9 Jun 2008 16:15:24 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: (qmail 6029 invoked by uid 399); 9 Jun 2008 16:15:24 -0000 Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 9 Jun 2008 16:15:24 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <484D5719.1070907@FreeBSD.org> Date: Mon, 09 Jun 2008 09:15:21 -0700 From: Doug Barton Organization: http://www.FreeBSD.org/ User-Agent: Thunderbird 2.0.0.14 (X11/20080606) MIME-Version: 1.0 To: Tim Kientzle References: <200805261721.m4QHLCF4070787@repoman.freebsd.org> <20080608075256.GA35560@obiwan.tataz.chchile.org> <484CB927.3050101@freebsd.org> In-Reply-To: <484CB927.3050101@freebsd.org> X-Enigmail-Version: 0.95.6 OpenPGP: id=D5B2F0FB X-Enigmail-Version: 0.95.6 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Jeremie Le Hen , cvs-all@freebsd.org Subject: Re: cvs commit [HEAD] src/gnu/usr.bin/cpio Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Jun 2008 16:15:25 -0000 Tim Kientzle wrote: > This case is a little unusual: by default, I want to > install both 'cpio' programs and symlink the common name > to one of them. I'm not sure how that relates to Jeremie's (valid) point that these flags need to be part of the system in bsd.own.mk. I admit that getting stuff in there was a little intimidating to me at first, but Ruslan has created a nice automated system, and he'll be glad to help you if you need it. > How about this: > WITH_GCPIO (default) - installs gcpio, symlinks 'cpio' unless > WITH_BSDCPIO defined > WITHOUT_GCPIO - does not install gcpio at all > WITH_BSDCPIO (default) - installs bsdcpio, symlinks 'cpio' > WITHOUT_BSDCPIO - does not install bsdcpio at all If by "not install" you mean "build or install" then I'm with you, but I think it might be a little complicated. I'm not sure why you want to build and install both by default (except maybe to ease people's concerns in the interim period) but if it were me, in HEAD I would do this: WITH_BSDCPIO (default) build, install, and symlink to cpio WITHOUT_GCPIO (default) do not build or install Then if WITHOUT_BSDCPIO is defined you don't build or install it, and if WITH_GCPIO is defined you build, install, and symlink it, regardless of the state of the BSDCPIO knob. When this gets MFC'ed I would just flip the defaults. FWIW, Doug -- This .signature sanitized for your protection