Date: Thu, 17 Jun 2004 14:28:40 +0200 From: Roman Neuhauser <neuhauser@chello.cz> To: Dan Langille <dan@langille.org> Cc: ports@FreeBSD.org Subject: Re: HEADS UP - master/slave ports Message-ID: <20040617122840.GB2664@isis.wad.cz> In-Reply-To: <40D1528D.31889.7ABCC38C@localhost> References: <40D14B14.5529.7A9F944C@localhost> <40D1528D.31889.7ABCC38C@localhost>
next in thread | previous in thread | raw e-mail | index | archive | help
# dan@langille.org / 2004-06-17 08:13:01 -0400: > On 17 Jun 2004 at 14:07, Roman Neuhauser wrote: > > # dan@langille.org / 2004-06-17 07:41:08 -0400: > > > On 17 Jun 2004 at 12:27, Roman Neuhauser wrote: > > > > # dan@langille.org / 2004-06-16 11:41:54 -0400: > > > > > +MASTERPORT!= ${ECHO_CMD} "${_MASTERDIR}" | ${SED} -Ee 's;^.*/([^/]+/[^/]+)/?$$;\1;' > > > > > > > > You don't need the sed, or rely on the fact that the category > > > > hierarchy is flat. Instead: > > > > > > > > _REALPORTSDIR!= ${REALPATH} "${PORTSDIR}" > > > > MASTERPORT= ${MASTERDIR:S#^${_REALPORTSDIR}##} > > > > > > I apologise for not giving credit to Mark Linimon for patch. > > > > > > Roman: I tried your patch. Here is what is does: > > > > > > [dan@polo:~/ports/www/mod_php4] $ make -V MASTERPORT -f ./Makefile > > > PORTSDIR=~/ports LOCALBASE=/nonexistentlocal X11BASE=/nonexistentx > > > Unknown modifier '`' > > > > replace the hashes, e. g.: > > > > MASTERPORT= ${MASTERDIR:S,^${_REALPORTSDIR}/,,} > > That's getting better: > > $ make -V MASTERPORT -f ./Makefile PORTSDIR=~/ports > LOCALBASE=/nonexistentlocal X11BASE=/nonexistentx > /www/mod_php4/../../lang/php4 > > But not the same as the original: > > $ make -V MASTERPORT -f ./Makefile PORTSDIR=~/ports > LOCALBASE=/nonexistentlocal X11BASE=/nonexistentx > lang/php4 Ugh, I see; I was confusing this with another feature... That would make it _REALPORTSDIR!= ${REALPATH} "${PORTSDIR}" _REALMASTERDIR!= ${REALPATH} "${MASTERDIR}" MASTERPORT= ${_REALMASTERDIR:S,^${_REALPORTSDIR}/,,} and I'm not sure that's any better than what you had originally. But, what will both versions output in databases/mysql40-client? -- If you cc me or remove the list(s) completely I'll most likely ignore your message. see http://www.eyrie.org./~eagle/faqs/questions.html
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040617122840.GB2664>