From owner-svn-ports-all@FreeBSD.ORG  Mon May 13 00:32:31 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 67861E23; Mon, 13 May 2013 00:32:31 +0000 (UTC)
Date: Mon, 13 May 2013 00:32:31 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Mark Linimon <linimon@lonesome.com>
Subject: Re: svn commit: r317934 - in head/games: doom-data duke3d-data
 quake-data quake2-data quake3-data
Message-ID: <20130513003231.GC32639@FreeBSD.org>
References: <201305120806.r4C86W9X001716@svn.freebsd.org>
 <20130512183849.GA19247@lonesome.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130512183849.GA19247@lonesome.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 May 2013 00:32:31 -0000

On Sun, May 12, 2013 at 01:38:49PM -0500, Mark Linimon wrote:
> On Sun, May 12, 2013 at 08:06:32AM +0000, Alexey Dokuchaev wrote:
> > Log:
> >   If port is setting PKGNAMEPREFIX=${FOOPKGNAMEPREFIX}, but .include's this
> >   file before <bsd.port.options.mk>, options handling gets broken because
> >   options will be loaded from OPTIONSFILE which is based on UNIQUENAME and
> >   thus PKGNAMEPREFIX, which is empty at that point.  Prevent this: ensure
> >   that FOOPKGNAMEPREFIX is defined in advance for ports that use it to set
> >   their PKGNAMEPREFIX and having OPTIONS.
> 
> As I feared, this commit broke INDEX.  Please see
> http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/dads-dot-error.html .

Sorry for that.  I suppose my r317936 fixed that, did it?

I'll see if I can avoid using .error though.

./danfe