From owner-freebsd-scsi@FreeBSD.ORG  Fri Feb 27 22:01:43 2004
Return-Path: <owner-freebsd-scsi@FreeBSD.ORG>
Delivered-To: freebsd-scsi@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 93E5916A4CE
	for <scsi@freebsd.org>; Fri, 27 Feb 2004 22:01:43 -0800 (PST)
Received: from panzer.kdm.org (panzer.kdm.org [216.160.178.169])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1C84843D1D
	for <scsi@freebsd.org>; Fri, 27 Feb 2004 22:01:43 -0800 (PST)
	(envelope-from ken@panzer.kdm.org)
Received: from panzer.kdm.org (localhost [127.0.0.1])
	by panzer.kdm.org (8.12.9/8.12.5) with ESMTP id i1S61gLX074011;
	Fri, 27 Feb 2004 23:01:42 -0700 (MST)
	(envelope-from ken@panzer.kdm.org)
Received: (from ken@localhost)
	by panzer.kdm.org (8.12.9/8.12.5/Submit) id i1S61fI0074010;
	Fri, 27 Feb 2004 23:01:41 -0700 (MST)
	(envelope-from ken)
Date: Fri, 27 Feb 2004 23:01:41 -0700
From: "Kenneth D. Merry" <ken@kdm.org>
To: Colin Percival <colin.percival@wadham.ox.ac.uk>
Message-ID: <20040228060141.GA73983@panzer.kdm.org>
References: <6.0.1.1.1.20040228020016.03f029e0@imap.sfu.ca>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6.0.1.1.1.20040228020016.03f029e0@imap.sfu.ca>
User-Agent: Mutt/1.4.1i
cc: scsi@freebsd.org
Subject: Re: Fwd: commit approval?
X-BeenThere: freebsd-scsi@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: SCSI subsystem <freebsd-scsi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-scsi>
List-Post: <mailto:freebsd-scsi@freebsd.org>
List-Help: <mailto:freebsd-scsi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-scsi>,
	<mailto:freebsd-scsi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 28 Feb 2004 06:01:43 -0000

On Sat, Feb 28, 2004 at 02:02:46 +0000, Colin Percival wrote:
>   I don't think anyone approved this patch -- is it ok with you guys?

Approved.

Sorry for the delay in responding.

> Colin Percival
> 
> >> Compare the *number* of patterns to zero, not the *pointer* to the
> >> patterns.  (These lines are correct the other two times they appear.)
> >>
> >> Reported by:  "Ted Unangst" <tedu@coverity.com>
> >>
> >> Index: src/sys/cam/cam_xpt.c
> >> ===================================================================
> >> RCS file: /home/ncvs/src/sys/cam/cam_xpt.c,v
> >> retrieving revision 1.135
> >> diff -u -r1.135 cam_xpt.c
> >> --- src/sys/cam/cam_xpt.c     9 Nov 2003 02:22:33 -0000       1.135
> >> +++ src/sys/cam/cam_xpt.c     20 Feb 2004 15:34:32 -0000
> >> @@ -1882,7 +1882,7 @@
> >>       * If there are no match entries, then this device matches no
> >>       * matter what.
> >>       */
> >> -     if ((patterns == NULL) || (patterns == 0))
> >> +     if ((patterns == NULL) || (num_patterns == 0))
> >>               return(DM_RET_DESCEND | DM_RET_COPY);
> >>
> >>       for (i = 0; i < num_patterns; i++) {
> 

Ken
-- 
Kenneth Merry
ken@kdm.org