Date: Fri, 26 Jun 2020 08:11:36 -0700 From: Cy Schubert <Cy.Schubert@cschubert.com> To: Mathieu Arnold <mat@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Fernando Apestegu??a <fernape@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540489 - in head/devel/fhist: . files Message-ID: <202006261511.05QFBaAk045418@slippy.cwsent.com> In-Reply-To: <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc> References: <202006261034.05QAYaDe038059@repo.freebsd.org> <20200626124105.GA65385@FreeBSD.org> <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc>, Mathieu Arnold w rites: > > --fq3my2lrxbkpfplh > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote: > > On Fri, Jun 26, 2020 at 10:34:36AM +0000, Fernando Apestegu??a wrote: > > > New Revision: 540489 > > > URL: https://svnweb.freebsd.org/changeset/ports/540489 > > >=20 > > > Log: > > > devel/fhist: and fix bison issues and change maintership > > >=20 > > > Modified: > > > head/devel/fhist/Makefile > > > head/devel/fhist/files/patch-common_ac_time.h > > >=20 > > > Modified: head/devel/fhist/files/patch-common_ac_time.h > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D > > > --- head/devel/fhist/files/patch-common_ac_time.h Fri Jun 26 09:35:06 2= > 020 (r540488) > > > +++ head/devel/fhist/files/patch-common_ac_time.h Fri Jun 26 10:34:36 2= > 020 (r540489) > > > @@ -1,6 +1,6 @@ > > > ---- common/ac/time.h.orig Wed Dec 18 02:09:57 2002 > > > -+++ common/ac/time.h Wed Dec 18 02:10:04 2002 > > > -@@ -29,7 +29,7 @@ > > > +--- common/ac/time.h.orig 2012-07-13 04:47:15 UTC > > > ++++ common/ac/time.h > > > +@@ -26,7 +26,7 @@ > > > * Catch-22: Dec Alpha OSF/1: need to include time.h before sys/time.h > > > * before time.h > > > */ > >=20 > > Please, "svn revert" patches which forwent no functional changes prior > > to making commit. It just clutters the diff and decreases SNR. :-( > > In that particular case, it was correct to commit the patch, it has > functional change, the range information changed, and it is definitively > not just noise. I see no problem regenerating patches. I do have a problem with cosmetic changes intermixed with functional changes like fix X and portlint, or fix X and regenerate patches. Keep them separate. They're easier for people reading the logs to parse weeks or months from now. -- Cheers, Cy Schubert <Cy.Schubert@cschubert.com> FreeBSD UNIX: <cy@FreeBSD.org> Web: https://FreeBSD.org NTP: <cy@nwtime.org> Web: https://nwtime.org The need of the many outweighs the greed of the few.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202006261511.05QFBaAk045418>