From owner-svn-ports-all@freebsd.org Fri Jun 26 15:11:44 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7B66535A08E; Fri, 26 Jun 2020 15:11:44 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-no.shaw.ca (smtp-out-no.shaw.ca [64.59.134.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 49tgMg1xVSz4kbS; Fri, 26 Jun 2020 15:11:42 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id oq0wjzbvU62broq0yjAiDE; Fri, 26 Jun 2020 09:11:40 -0600 X-Authority-Analysis: v=2.3 cv=LKf9vKe9 c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=xqWC_Br6kY4A:10 a=kj9zAlcOel0A:10 a=nTHF0DUjJn0A:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=EkcXrb_YAAAA:8 a=RntPe48znTAUQTSo858A:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=LK5xJRSDVpKd5WXXoEvA:22 Received: from slippy.cwsent.com (slippy [IPv6:fc00:1:1:1::5b]) by spqr.komquats.com (Postfix) with ESMTPS id 70CB5765; Fri, 26 Jun 2020 08:11:37 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id 05QFBa4Y045421; Fri, 26 Jun 2020 08:11:36 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id 05QFBaAk045418; Fri, 26 Jun 2020 08:11:36 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <202006261511.05QFBaAk045418@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Mathieu Arnold cc: Alexey Dokuchaev , Fernando Apestegu??a , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r540489 - in head/devel/fhist: . files In-reply-to: <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc> References: <202006261034.05QAYaDe038059@repo.freebsd.org> <20200626124105.GA65385@FreeBSD.org> <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc> Comments: In-reply-to Mathieu Arnold message dated "Fri, 26 Jun 2020 15:28:41 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 26 Jun 2020 08:11:36 -0700 X-CMAE-Envelope: MS4wfOWOrHSW6tFupAyvD2y/ndDEPGoLtUx2LEebwyG/3hvEjx6pHcKzCt00yLFBk5V/j9WrKT4+2BsSkql5Qd9im+CADDzd9PGgeNWdDB5nSuyx/SGWZJXn lpypScbDWgggAYBOuempPe8z46uLpaJymuoK6QW05bkkKYrPHkaUAHicLXL0ocd/M06WLkmK0fM8qkF9fIovi7J5i3IWxnNe+4qL+9Hf94zH01qo1qsX3UpV vyh6ZHPVfM8c+P1k+OkR+YoWZ7EFnqADSAICH0POPABOH9ij9kMannl5SJ0zWnSOIqbKgzDgNxWGLXu5PTlMb566mVtoyeUgpG7c3ttA4wg1qjwFxb07sl76 iNt7YLmJ X-Rspamd-Queue-Id: 49tgMg1xVSz4kbS X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of cy.schubert@cschubert.com has no SPF policy when checking 64.59.134.9) smtp.mailfrom=cy.schubert@cschubert.com X-Spamd-Result: default: False [1.19 / 15.00]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; RWL_MAILSPIKE_GOOD(0.00)[64.59.134.9:from]; HAS_XAW(0.00)[]; RCPT_COUNT_FIVE(0.00)[6]; RECEIVED_SPAMHAUS_PBL(0.00)[70.67.125.17:received]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; RCVD_IN_DNSWL_LOW(-0.10)[64.59.134.9:from]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.57)[-0.571]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; AUTH_NA(1.00)[]; NEURAL_SPAM_MEDIUM(0.29)[0.293]; DMARC_NA(0.00)[cschubert.com: no valid DMARC record]; NEURAL_SPAM_SHORT(0.17)[0.172]; R_SPF_NA(0.00)[no SPF record] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Jun 2020 15:11:44 -0000 In message <20200626132841.kytmjwquonpwkrhr@aching.in.mat.cc>, Mathieu Arnold w rites: > > --fq3my2lrxbkpfplh > Content-Type: text/plain; charset=us-ascii > Content-Disposition: inline > Content-Transfer-Encoding: quoted-printable > > On Fri, Jun 26, 2020 at 12:41:05PM +0000, Alexey Dokuchaev wrote: > > On Fri, Jun 26, 2020 at 10:34:36AM +0000, Fernando Apestegu??a wrote: > > > New Revision: 540489 > > > URL: https://svnweb.freebsd.org/changeset/ports/540489 > > >=20 > > > Log: > > > devel/fhist: and fix bison issues and change maintership > > >=20 > > > Modified: > > > head/devel/fhist/Makefile > > > head/devel/fhist/files/patch-common_ac_time.h > > >=20 > > > Modified: head/devel/fhist/files/patch-common_ac_time.h > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= > =3D=3D=3D=3D=3D > > > --- head/devel/fhist/files/patch-common_ac_time.h Fri Jun 26 09:35:06 2= > 020 (r540488) > > > +++ head/devel/fhist/files/patch-common_ac_time.h Fri Jun 26 10:34:36 2= > 020 (r540489) > > > @@ -1,6 +1,6 @@ > > > ---- common/ac/time.h.orig Wed Dec 18 02:09:57 2002 > > > -+++ common/ac/time.h Wed Dec 18 02:10:04 2002 > > > -@@ -29,7 +29,7 @@ > > > +--- common/ac/time.h.orig 2012-07-13 04:47:15 UTC > > > ++++ common/ac/time.h > > > +@@ -26,7 +26,7 @@ > > > * Catch-22: Dec Alpha OSF/1: need to include time.h before sys/time.h > > > * before time.h > > > */ > >=20 > > Please, "svn revert" patches which forwent no functional changes prior > > to making commit. It just clutters the diff and decreases SNR. :-( > > In that particular case, it was correct to commit the patch, it has > functional change, the range information changed, and it is definitively > not just noise. I see no problem regenerating patches. I do have a problem with cosmetic changes intermixed with functional changes like fix X and portlint, or fix X and regenerate patches. Keep them separate. They're easier for people reading the logs to parse weeks or months from now. -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org The need of the many outweighs the greed of the few.