From owner-cvs-all  Tue Nov 14 11:24:16 2000
Delivered-To: cvs-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 618)
	id BCB1E37B479; Tue, 14 Nov 2000 11:24:12 -0800 (PST)
Subject: Re: cvs commit: src/sys/dev/an if_aironet_ieee.h if_an.c if_anreg.h         src/usr.sbin/ancontrol ancontrol.8 ancontrol.c
In-Reply-To: <200011140534.eAE5YOw05604@white.dogwood.com> from Dave Cornejo at "Nov 13, 2000 09:34:24 pm"
To: dave@dogwood.com (Dave Cornejo)
Date: Tue, 14 Nov 2000 11:24:12 -0800 (PST)
Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Message-Id: <20001114192412.BCB1E37B479@hub.freebsd.org>
From: wpaul@FreeBSD.ORG (Bill Paul)
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

> I had corresponded with Doug right after I submitted the PR and we had
> agreed that my .h files were better and that his .c & ancontrol files
> were better.

Well, you left me little choice since you didn't actually provide
changes for ancontrol.

> There is one glaring problem with the committed .h files and that is
> that the settings in the authtype field are wrong.  You cannot
> actually set encryption properly with either the original or the
> committed files.
> 
> There is, contrary to earlier Aironet documentation, no such bit as
> AN_AUTHTYPE_EXCLUDE_UNENCRYPTED.
> 
> The correct AN_AUTHTYPES are as follows:
> 
> #define AN_AUTHTYPE_NONE                        0x0000
> #define AN_AUTHTYPE_OPEN                        0x0001
> #define AN_AUTHTYPE_SHAREDKEY                   0x0002
> #define AN_AUTHTYPE_PRIVACY_IN_USE              0x0002
> #define AN_AUTHTYPE_ALLOW_UNECNRYPTED           0x0002
> 
> (I'm pretty certain these are what I called them in my patch, but I'm
> doing this from memory)

The patch submitted with your PR does not mention these bit definitions
at all. Also, I'm really confused as to why the last three definitions
are all the same (0x0002). That doesn't seem to make sense. 
 
> There are also some other things in my patch that fix errors in some
> of the structures (minor) and add support for some other interesting
> things in upcoming versions.

I merged in your structure changes, except for one which conflicted
with Doug's changes.

Look, I don't have a card here for testing: why don't you sort out
how this is supposed to work, verify that it functions with a real
card, then submit a context diff to me.

-Bill 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message