From owner-svn-src-head@freebsd.org Tue May 29 13:57:42 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9CA31F7EA80; Tue, 29 May 2018 13:57:42 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 0032C6BDB6; Tue, 29 May 2018 13:57:41 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id Nf86frnjySzNNNf87fEV8w; Tue, 29 May 2018 07:57:40 -0600 X-Authority-Analysis: v=2.3 cv=KuxjJ1eN c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=8nJEP1OIZ-IA:10 a=VUJBJC2UJ8kA:10 a=ndaoGXS1AAAA:8 a=YxBL1-UpAAAA:8 a=6I5d2MoRAAAA:8 a=5qHmQeo1rNjm-hv6de8A:9 a=wPNLvfGTeEIA:10 a=mFeOnlTyF09QQMGr2mMI:22 a=Ia-lj3WSrqcvXOmTRaiG:22 a=IjZwj45LgO3ly-622nXo:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 3939C838; Tue, 29 May 2018 06:57:38 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w4TDvb49074606; Tue, 29 May 2018 06:57:37 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w4TDvbkS074594; Tue, 29 May 2018 06:57:37 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201805291357.w4TDvbkS074594@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Hans Petter Selasky cc: Cy Schubert , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r334320 - in head/sys: cddl/compat/opensolaris/kern cddl/compat/opensolaris/sys i386/include In-Reply-To: Message from Hans Petter Selasky of "Tue, 29 May 2018 15:45:18 +0200." Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Tue, 29 May 2018 06:57:37 -0700 X-CMAE-Envelope: MS4wfCebwJWedOZC20qguS5tE2iunhrUlntNHBfcjeXLFoKvYNsZeGEMk0q1Z0xMQq0+j1jeokm1q3Pb50os7puL/zQnx+mWSPfv2lwLB8oH5k+4IsapWfrR Rb19y1nwUIHuSR6IDz7OzxF+ieB25T2dFqGwlOZcX5I2rHnFfBCAYbd0kA3CUWtwyeLZPnSG/f2P2Xc69doX8L0FiipC1PANSFd+ouMKRvYsnaJlmebnxCKw 44iQKZarlDAsRdWtw4ylwg== X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 13:57:42 -0000 In message , Hans Petter Sela sky writes: > On 05/29/18 15:10, Hans Petter Selasky wrote: > >> Hi Hans, > >> > >> This broke in lib32 on an amd64 system. > >> > >> --- cddl/lib/libnvpair__L --- > >> In file included from /opt/src/svn-current/sys/cddl/contrib/opensolaris/ > >> common/nvpair/opensolaris_fnvpair.c:29: > >> In file included from /opt/src/svn-current/cddl/contrib/opensolaris/lib/ > >> libzpool/common/sys/zfs_context.h:74: > >> /opt/src/svn-current/sys/cddl/compat/opensolaris/sys/atomic.h:94:2: > >> error: implicit declaration of function 'atomic_subtract_64' is invalid > >> in C99 [-Werror,-Wimplicit-function-declaration] > >>          atomic_subtract_64(target, 1); > >>          ^ > > > > I only tested buildkernel i386 LINT + GENERIC with this change. I will > > have a look ASAP. > > > > --HPS > > See r334328 . Thanks. I'll let it build while I'm at $JOB and check it at noon. -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.