From owner-svn-ports-head@freebsd.org Sun May 6 15:51:55 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 88836FBDE79; Sun, 6 May 2018 15:51:55 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3C0737721E; Sun, 6 May 2018 15:51:55 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 198FD1D50C; Sun, 6 May 2018 15:51:55 +0000 (UTC) Date: Sun, 6 May 2018 15:51:55 +0000 From: Alexey Dokuchaev To: Koichiro Iwao Cc: Kurt Jaeger , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r469188 - head/ports-mgmt/pkg_replace Message-ID: <20180506155155.GC79630@FreeBSD.org> References: <201805061015.w46AF3HQ070595@repo.freebsd.org> <20180506102749.GA58637@FreeBSD.org> <20180506103420.GW25490@fc.opsec.eu> <20180506105012.GA39087@FreeBSD.org> <01010163359962dc-36ee8574-dbd7-4cc6-8032-e04a80a18f1e-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01010163359962dc-36ee8574-dbd7-4cc6-8032-e04a80a18f1e-000000@us-west-2.amazonses.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 May 2018 15:51:55 -0000 On Sun, May 06, 2018 at 01:17:14PM +0000, Koichiro Iwao wrote: > On Sun, May 06, 2018 at 10:50:12AM +0000, Alexey Dokuchaev wrote: > > *facepalm*. This poudriere-driven development is more and more disturbing. > > You didn't attempt to understand the problem, you didn't attempt to fix the > > PLIST_FILES (remove bogus %%ETCDIR%% since this is Makefile), you didn't > > ask for a peer review. meta@ pessimized the port, provided wrong commit > > log (it tells *nothing* about poudriere failing with a signal 6 in make > > package, it says "pet portlint"), and you've approved it like there's > > nothing wrong with all of this. :-( > > Sorry about that. I understand what I should have done and I could do. Oh I don't blame you at all. Your mentor is currently earning all the pointy hats. :-) > Then what should I do next? Should I turn back to PLIST_FILES? That would be what we call "gratuitous change" here. The deed was done, if it works, leave it. You might want to revisit it later alongside with other changes. > What should I do from the next time not to repeat such a folly? Study PHB and other people's work (I understand that not everyone has time or desire to read through all svn-ports-* emails, but being a new committer it could be helpful for you at least in the beginning). Study other ports, often they can offer nice a idea (bad ones as well, more often). Question your decisions, question others' decisions, when it doubt, ask for a peer review. There are quite a few highly qualified and experienced committers. ./danfe