From owner-cvs-src@FreeBSD.ORG  Wed Jan 14 10:55:53 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C3C2916A4CF
	for <cvs-src@FreeBSD.org>; Wed, 14 Jan 2004 10:55:53 -0800 (PST)
Received: from root.org (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id A8EF743D48
	for <cvs-src@FreeBSD.org>; Wed, 14 Jan 2004 10:55:48 -0800 (PST)
	(envelope-from nate@root.org)
Received: (qmail 67272 invoked by uid 1000); 14 Jan 2004 18:55:49 -0000
Date: Wed, 14 Jan 2004 10:55:49 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: cvs-all@FreeBSD.org, cvs-src@FreeBSD.org,
	src-committers@FreeBSD.org
In-Reply-To: <20040114185436.9BD8F16A540@hub.freebsd.org>
Message-ID: <20040114105507.D67236@root.org>
References: <20040114185436.9BD8F16A540@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: cvs commit: src/sys/contrib/dev/acpica exstore.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jan 2004 18:55:53 -0000

On Wed, 14 Jan 2004, Nate Lawson wrote:
>   Modified files:        (Branch: INTEL)
>     sys/contrib/dev/acpica exstore.c
>   Log:
>   When creating a package element via "Store(0xXXX, Index(ArgX, 0xXXX))",
>   be sure to increment the refcount of the argument so it is not
>   prematurely deleted.  This is a workaround and may appear in a different
>   form in ACPI-CA.  This fixes battery evaluation on Thinkpads that was
>   broken by fixing the Dell battery state.
>
>   Submitted by:   Luming Yu <luming.yu@intel.com>
>
>   Revision  Changes    Path
>   1.1.1.23  +1 -1      src/sys/contrib/dev/acpica/exstore.c
>
> --- src/sys/contrib/dev/acpica/exstore.c:1.1.1.22	Mon Dec  8 18:43:40 2003
> +++ src/sys/contrib/dev/acpica/exstore.c	Wed Jan 14 10:54:22 2004
> @@ -389,7 +389,7 @@
>
>              /* If same as the original source, add a reference */
>
> -            if (NewDesc == SourceDesc)
> +            if (NewDesc == SourceDesc || ObjDesc == NULL)
>              {
>                  AcpiUtAddReference (NewDesc);
>              }
>

Ok, done on the right branch this time.  Thanks to markm for repo work to
fix my mistake.

-Nate