From owner-cvs-src  Sun Mar 16  3:31:41 2003
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E75AB37B404; Sun, 16 Mar 2003 03:31:32 -0800 (PST)
Received: from smtp01.syd.iprimus.net.au (smtp01.syd.iprimus.net.au [210.50.30.70])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7ECF343F93; Sun, 16 Mar 2003 03:31:31 -0800 (PST)
	(envelope-from tim@robbins.dropbear.id.au)
Received: from dilbert.robbins.dropbear.id.au ([210.50.221.219]) by smtp01.syd.iprimus.net.au with Microsoft SMTPSVC(5.0.2195.5600);
	 Sun, 16 Mar 2003 22:31:27 +1100
Received: from dilbert.robbins.dropbear.id.au (b31ta59q1auxkzop@localhost [127.0.0.1])
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6) with ESMTP id h2GBVEJK084893;
	Sun, 16 Mar 2003 22:31:14 +1100 (EST)
	(envelope-from tim@dilbert.robbins.dropbear.id.au)
Received: (from tim@localhost)
	by dilbert.robbins.dropbear.id.au (8.12.6/8.12.6/Submit) id h2GBVCqW084892;
	Sun, 16 Mar 2003 22:31:12 +1100 (EST)
	(envelope-from tim)
Date: Sun, 16 Mar 2003 22:31:11 +1100
From: Tim Robbins <tjr@FreeBSD.org>
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/fs/udf udf_vnops.c
Message-ID: <20030316223111.A84750@dilbert.robbins.dropbear.id.au>
References: <200303161119.h2GBJsXQ091753@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <200303161119.h2GBJsXQ091753@repoman.freebsd.org>; from tjr@FreeBSD.org on Sun, Mar 16, 2003 at 03:19:54AM -0800
X-OriginalArrivalTime: 16 Mar 2003 11:31:29.0775 (UTC) FILETIME=[9691FFF0:01C2EBAF]
Sender: owner-cvs-src@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-src.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-src>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-src>
X-Loop: FreeBSD.ORG

On Sun, Mar 16, 2003 at 03:19:54AM -0800, Tim J. Robbins wrote:

> tjr         2003/03/16 03:19:54 PST
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/fs/udf           udf_vnops.c 
>   Log:
>   Make udf_allocv() return an unlocked vnode instead of a locked one
>   to avoid a "locking against myself" panic when udf_hashins() tries
>   to lock it again. Lock the vnode in udf_hashins() before adding it to
>   the hash bucket.
>   
>   Revision  Changes    Path
>   1.25      +1 -2      src/sys/fs/udf/udf_vnops.c

It looks like there is a race between checking whether the vnode is
already in the hash table, and allocating then adding it. It also looks
like the cd9660 code that tries to avoid this race is broken. Anyone
want to investigate these two?


Tim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message