From owner-freebsd-current@freebsd.org Wed Jun 19 19:54:06 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 11E8515C829E for ; Wed, 19 Jun 2019 19:54:06 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 8D74177B58 for ; Wed, 19 Jun 2019 19:54:05 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: by mailman.ysv.freebsd.org (Postfix) id 4D46215C829D; Wed, 19 Jun 2019 19:54:05 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2AA1D15C829C for ; Wed, 19 Jun 2019 19:54:05 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id BDF5177B57; Wed, 19 Jun 2019 19:54:04 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id 4AD77128A7; Wed, 19 Jun 2019 19:54:04 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 6538C1BB9; Wed, 19 Jun 2019 19:54:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id xODAs09_i-yy; Wed, 19 Jun 2019 19:53:57 +0000 (UTC) Subject: Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com BD3FF1BA6 To: "Julian H. Stacey" , current@freebsd.org References: <201906180147.x5I1ksVi028507@fire.js.berklix.net> From: Bryan Drewery Openpgp: preference=signencrypt Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAG0JEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPokBVwQTAQoAQQIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZARYhBPkXPLLDqup6XIofCTXXcbtuRpfPBQJb5hLu BQkNPvODAAoJEDXXcbtuRpfP9rMH/3f7cfX5rzyEV5QNfV/wS4jFukLoPZ4+nCM/TKxH3pEX 2bLbeQbkk6La8cueQ5Lpoht5XFZ18Y5TbMittngltrlNzoDD0h9are24OkDFGim3afJU7tkj IGQa1if+re+vI5BhzYwRhj0oKXzBi39M5oePd3L1dXfx83rg2FPyZBdIejsz6fR74T3JVkbd 6k2l5/3Zk2uiNMy+eBfDRgYE1E6CP28kV0nCeGKZgSVso0kGUUHud7voKqGVpMvbd0mE4pp4 PE5YJaFPjrll9miaDAvdU8LGIq5n6+aXPLKoQ/QNl6mg6ifgI6FfKILOkTizLW8E5PBSNnCm NapQ55yjm125AQ0EUmmGawEIAKJUU9+Q19oW1RK5jTf3m56j+szIc8Y9DaLC8REUKl4UZJBK BqCl6c0cukVApOD92XoU6hJPm2rLEyp/IcYcPPNTnVu8D8h9oag2L8EiFN7+2hk0xG+lwjc8 uOIZycme7AIJsBU4AZ1v63lxm2k104hwpiatgbe71GIGl7p1MX6ousP/wGzXCOF25Dx9w02C eRe7zEMfhnFjSUhzdCC9han2+KaVB7qIqNR3b8NfbwRNlwPmHqlhXffUow9OsQjSnTK8WKNR lx7xzVccXIvWP2wECFrmqmzMmXpSrmIuiWEpFwZ9x2a0Pva8dCNRiCVTK51IlRXKjaAxiN1u IUrMm6UAEQEAAYkBJQQYAQoADwUCUmmGawIbDAUJCWYBgAAKCRA113G7bkaXz1Q+CADaYZCn bzIJQqwnoocVXL+Wkd+hCsoX6zsd8pNTY5tV5U1fgjxl1bVQ7jyZGrEQ7BjyvlhIfpfTo6aK oJfZpIxeDc3Tr+X7O2UHT5QYaWRcGO+X3+eKL5sLpvxda67RftClv2hgEr1i2hqjK5WmUCaN 2P9w+i7rmZ4ohpLXINOMeHjnQOtbxCCF7qXRsVfgEcpNKb31T3QwvsRjX0HqIjYFlKpa61Wz IPvWgBERjo0aAOkI4g7oVLjX5Z5gINGPy+xr8GJqhfZ3ZIEOwLCwTB71+Dk9gyLa5UiG8vo6 vGfA50H5OSC87LnNlI07b1Qb8mKVkqg13PbCkRpTMKEYaou9iQElBBgBCgAPAhsMBQJa6M4o BQkKYHs9AAoJEDXXcbtuRpfPpuQH/0d1RHcTTAHAyHrPQA4UMqH49tEj1d3gidx2ETnm00rj XTrnRreAAMgPCrPeLvYYiKeSBrHOkQ7E/Vuztr4F4Xenld3omOTon+cSyGKyA1btWNRskcUa zxJ/0DqgzerhWQj8CtWjmqRnGAqzvZQdIDLk1X4B2p1Ota4AvbTF9DqADskXfld/zPJQzYYy XRfyKTt0nWMyn5MHbsuKmpsOBqYXMf0X2EL2C6v3g5D/HedD6YVnW6KlgcDUR2sq6Fv9Ozhs 38TOXyeZgbFz0HDtkHEY5Mh3+sQjOh4takC+Dp1zDRP2U19JZzo9f6R/d05c0h2TD02oogPz AQ97xrFwZgaJATwEGAEKACYCGwwWIQT5Fzyyw6rqelyKHwk113G7bkaXzwUCW+YS+AUJDT7z jQAKCRA113G7bkaXzwo3B/4rwbDqXaXm6YC4s0jVOf1+MljeQIsbHPVQZ0IRigCpzCDSUFTK QOebA9iUj8JaF2DPwd6sjyUUv/XMCLl+SwzSijmVN0Kfk85XspzNef8XmteKK1mERkYnLWBw TNwp6qezg/CukNbobNH08ciT+z2fxtPuwqK5X9Q5R4Q7egth5XUTxbwLwIJerEfVs4HG+687 m9h1bWyYJemB24MgBu8fTaVxas8dSSwDHabdgyGMKIvqDHUUJQSMDbio0Iwhs7lx2p3Xd5Br wQLMiaUPnKBHqfVM8ADWldvHF6xa9keBUjnEedKwQNjYf76lGH6bLwbyZcLigKFdXY1R2ooT Xi+R Organization: FreeBSD Message-ID: Date: Wed, 19 Jun 2019 12:53:56 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <201906180147.x5I1ksVi028507@fire.js.berklix.net> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mL69AvO5irWNxdQRD16AEV1FxTwf3cNbm" X-Rspamd-Queue-Id: BDF5177B57 X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.97 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.997,0]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; ASN(0.00)[asn:11403, ipnet:96.47.64.0/20, country:US]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2019 19:54:06 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mL69AvO5irWNxdQRD16AEV1FxTwf3cNbm Content-Type: multipart/mixed; boundary="QoTOd9y7Qmnl3CHXIVnCVHCHF6mLpispQ"; protected-headers="v1" From: Bryan Drewery To: "Julian H. Stacey" , current@freebsd.org Message-ID: Subject: Re: sys/modules/sdio broken in .svn_revision 348842 'opt_cam.h' not found References: <201906180147.x5I1ksVi028507@fire.js.berklix.net> In-Reply-To: <201906180147.x5I1ksVi028507@fire.js.berklix.net> --QoTOd9y7Qmnl3CHXIVnCVHCHF6mLpispQ Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/17/19 6:46 PM, Julian H. Stacey wrote: > Hi, Reference: >> From: Ian Lepore >> Date: Mon, 17 Jun 2019 18:56:35 -0600 >=20 > Ian Lepore wrote: >> On Tue, 2019-06-18 at 02:21 +0200, Julian H. Stacey wrote: >>> "Julian H. Stacey" wrote: >>>> "Bjoern A. Zeeb" wrote: >>>>> On 17 Jun 2019, at 10:37, Mark Linimon wrote: >>>>> >>>>>> On Mon, Jun 17, 2019 at 11:41:03AM +0200, Julian H. Stacey >>>>>> wrote: >>>>>>> svn_revision 348842 >>>>>> >>>>>> [ ...] >>>>>>> /usr/src/sys/modules/sdio/../../dev/sdio/sdiob.c:68:10: fatal >>>>>>> error: >>>>>>> 'opt_cam.h' file not found >>>>>>> #include "opt_cam.h" >>>>>>> ^~~~~~~~~~~ >>>>>>> 1 error generated. >>>>>> >>>>>> This is extremely unlikely to be r348842. I would investigate >>>>>> r349025 >>>>>> instead. (Committer Cc:ed.) >>>>> >>>>> Almost, more likely me. I just had a look. I am not exactly >>>>> sure how=20 >>>>> to reproduce this? >>>>> >>>>> /bz >>>> >>>> If I can help let me know. >>>> My buildworld broke with 13.0-CURRENT=20 >>>> /usr/src .ctm_status src-cur 14077 .svn_revision 348842 >>>> I'm now running make install,=20 >>>> & can then compare my root include & libs with with a set >>>> installed=20 >>>> using DESTDIR=3D >>> >>> I compiled, installed, compared. =20 >>> BTW cd /usr/src; make delete - only cleans libs & bins but does >>> not >>> clean other junk listed in ObsoleteFiles.inc not even with >>> -DBATCH_DELETE_OLD_FILES or -DBATCH_DELETE_OLD_FILES=3DYES so >>> manually purged, >>> I believe I have a clean system built from .ctm_status src-cur 14077 >>> .svn_revision 348842 but /usr/src/sys/modules/sdio still fails, >>> so there was a commit of unbuildable code. >>> >>> cd /usr/src ; find . -name opt_cam.h # tools/tools/vhba/opt_cam.h >>> cd /usr/include ; find . -name opt_cam.h # nothing >>> >>> >>>> I have a 2nd slower current box also building to 14077, I will then >>>> take that on up to latest .ctm_status src-cur 14087 .svn_revision >>>> 349129 to see if problem clears. >>> >>> make buildworld blew on newer current, with a different bug: >>> >>> cc -O2 -pipe -I/usr/src/usr.bin/mkesdb_static >>> -I/usr/src/usr.bin/mkesdb_static/../mkesdb - >>> I/usr/src/usr.bin/mkesdb_static/../../lib/libc/iconv -g -MD - >>> MF.depend.lex.o -MTlex.o -std=3Dgnu99 -Qunused-arguments - >>> I/usr/obj/usr/src/amd64.amd64/tmp/legacy/usr/include -c lex.c -o >>> lex.o >>> /usr/src/usr.bin/mkesdb/lex.l:46:10: fatal error: 'yacc.h' file not >>> found >>> #include "yacc.h" >>> ^~~~~~~~ >>> 1 error generated. >>> *** Error code 1 >>> >>> Stop. >>> make[3]: stopped in /usr/src/usr.bin/mkesdb_static >>> >>> A double waste of CPU & human time & power in a hot office. >>> Commit bits used to be suspended for un-buildable code. I'll boot >>> stable. >> >> Since you seem to be so focused on mean-spirited criticism of others, >> I'm sure you'll understand when I ask... >> >> Have you *seriosly* been using and building freebsd this long and you >> don't know that an opt_*.h file is generated as part of the build and >> exists only in the object directory, so that searching for it under >> /usr/src or /usr/include would be... let's see, how did you put it?...= >> Oh yeah: A double waste of CPU & human time. >=20 > Personal noise is irrelevant. >=20 > Facts:=20 > Unchecked commits broken make buildworld twice,=20 > Time was wasted by bad commits. =20 > My time ran out.=20 > Current does not benefit from commits that break buildworld. > I (like a friend before) must switch to stable to avoid breakage.=20 >=20 > Time was, ~25 years back, when FreeBSD commiters who screwed > the build were awarded a conical hat & took a one week holiday. A > mild rebuke for wasting people's time, & a short refreshing > break to go smell fresh air. No not coffee, but fresh air. >=20 > Cheers, > Julian >=20 As the committer who broke yacc.h I'm sorry. I understand the frustration. I too get frustrated by build breakage from others and even myself. I appreciate the cc's here. I did test this particular change with 1. clean build 2. -DNO_CLEAN 3. CLEANDIR=3Dclean + -DNO_CLEAN (to really rebuild everything but reuse the .depend files). And similar pattern with META_MODE. And a cross-build of powerpc.powerpc64 to capture some gcc deps and ensure cross-build was running the right binaries. I missed not using -j though, that's a really odd case I'll never test frankly. Worse my build environment had MK_TESTS=3Dno in it so I missed some other= bugs. What I didn't test: buildkernel, install*, universe, ports (the last 2 will likely bite me still). It's pretty common for all of us to forget to test installworld and ports= =2E Again this brings up the need for a real build test suite that can be used pre-commit. --=20 Regards, Bryan Drewery --QoTOd9y7Qmnl3CHXIVnCVHCHF6mLpispQ-- --mL69AvO5irWNxdQRD16AEV1FxTwf3cNbm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Rc8ssOq6npcih8JNddxu25Gl88FAl0KktQACgkQNddxu25G l8+eTggAiiP9B+6PrBxod5b5PJcso4aqVuZIZoFCeWA4MZbHUcdQRaPa53okwe0v j3l2/4suZ4GSaMXHL6B5Eq6JUsGL8f8hIUB4bsVvIRPgc1nyruMdsit6U4c277m9 S0c8T+weeRr6sASFCGtdwPDIyx86VWi39K1sCIDZnyI9cwbePL0sltkCVL6srPh5 VYsN5jADqZw5N1CAsKP1yu2fEY65hpzIfV4tCs9FNCXmUYNgIiniwSdNfNeCI8M8 ztmO38/jS5PS6rpYxIq4GuBiM5hB4C2bXZRoSJs+DyY5K948sNUulyDyhxhsoXk0 X+joAS1NKlq/2fUDgVnQ+DNJy6RyXA== =p6JU -----END PGP SIGNATURE----- --mL69AvO5irWNxdQRD16AEV1FxTwf3cNbm--